Comments (5)
I was wondering why the "Unknown" value wasn't automatically ignored by Auspice and found this was done on purpose!
nextclade/packages_rs/nextclade/src/tree/tree.rs
Lines 21 to 23 in ca54ba3
from nextclade.
Thanks Jover!
Since the beginning, we've been trying to carefully ignore the country and other values, because Nextclade inputs and, therefore, newly attached tree nodes simply don't have this information.
My understanding is that in our own datasets we don't have these fields, and so these colorings do not even appear in the dropdown.
I had to add the handling of unknown values long time ago for the reasons I don't remember clearly, but I found this Slack thread:
https://bedfordlab.slack.com/archives/C7SDVPBLZ/p1596559922285700?thread_ts=1596488014.283400&cid=C7SDVPBLZ
But maybe it needs to be revisited.
You know more about this things. What can you recommend?
from nextclade.
Ah, the grey scale is the intended behavior in Auspice for values that are not defined in the color scale.
Maybe the easiest thing to do here would be for Nextclade to use "Unknown"
(without the space at the end) so that the new tree nodes just don't have a country value? This way the new nodes will automatically get colored as grey for these colorings and you can remove the injection of the color scale.
from nextclade.
We have never been very careful about metadata other than clades on these trees. But many datasets 'inherit' these metadata attributes from the workflows they are based on.
I don't think I fully understand the problem yet though. If I look at these trees in auspice (outside of nextclade) they get assigned the default rainbow colors. Is it that only after adding the fake Unknown_
auspice then generates the grey values?
I don't remember all the reasons why we wanted to avoid auspice interpreting this as Unknown
. But I guess we can remove the space and see whether we get any unwanted behavior.
from nextclade.
Is it that only after adding the fake Unknown_ auspice then generates the grey values?
Yes, Nextclade injects a single color scale for the added Unknown_
value and Auspice will "create shades of grey for values in the tree which weren't defined in the provided scale".
Using the Influenza H1N1pdm HA dataset as an example, the "Region" color-by looks fine because tree.json includes a scale for region. However, the "Country" color-by is grey scale because the tree.json does not define a scale for country.
from nextclade.
Related Issues (20)
- 21L Tree Updates? HOT 2
- `--input-pcr-primers` listed in CLI help options despite being removed in v3 HOT 2
- When using `?input-fasta=` url query param without specifying dataset, web auto-starts analysis (prematurely) HOT 5
- Scrollbar shown for dataset names in dataset picker HOT 9
- how to generate the result table by the cli version auspice HOT 4
- output TSV column(s) for missing bases at beginning and end of sequence? HOT 1
- --input-dataset parameter HOT 5
- Update Fred Hutch logo
- How to get the latest Lineage- with CLI HOT 4
- Community build cache validity bug HOT 2
- Developer guide uses deprecated CLI option
- docs: document nextalign-like use-case HOT 1
- ENH(nextclade cli): nextclade dataset list: indicate whether clades can be assigned HOT 7
- nextclade run --output-columns-selection throws error for seqName and includes index even though I don't want index HOT 11
- Nextclade Web: Confusing unwanted dataset switching HOT 3
- Nextclade Web: consider rethinking dataset badges HOT 1
- Nextclade Web: don't store unnecessary dataset info in local storage
- [minor] Auspice dataset functionality: URL redirects don't update displayed metadata HOT 3
- Max marker setting even counts markers that are off
- Frameshift and insertion markers cannot be disabled/configured in contrast to all other markers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nextclade.