Giter VIP home page Giter VIP logo

Comments (4)

joverlee521 avatar joverlee521 commented on August 19, 2024 1

The seasonal-flu build's tree JSONs are missing the xvalue attribute leading to a NaN value in the nextflu code.
The xvalue attribute should be included in the augur v1 export, but it's not guaranteed since it's technically a deprecated attribute.

from seasonal-flu.

huddlej avatar huddlej commented on August 19, 2024 1

Great catch! Would it be reasonable to update the calculation of branch lengths in nextflu to use the branch_length attribute we export in the auspice JSONs instead of the missing xvalue parameter?

We probably don't want to start exporting a deprecated field just for nextflu and updating the nextflu code would allow all existing datasets to work as they are without regenerating them...

from seasonal-flu.

joverlee521 avatar joverlee521 commented on August 19, 2024

When the "timetree" is off, the d3 x value gets assigned to the xvalue. So all downstream d3 transformations error out with the NaN x value.

from seasonal-flu.

joverlee521 avatar joverlee521 commented on August 19, 2024

If I assign the d3 x value to node.attr['div'], this results in a divergence view with no gridlines. From what I can see, the drawGrid() function only applies to the timetree view. Is this the expected behavior?

Screen Shot 2021-04-21 at 10 21 55 AM

Edit: see blab/nextflu#154

from seasonal-flu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.