Giter VIP home page Giter VIP logo

Comments (3)

jfy133 avatar jfy133 commented on August 15, 2024

We've hit a problem with optionally including annotated contigs as input.

I've actually got this working, however the code has got quite messy now. But this has also led to two issues which makes me feel like I would rather not support this:

  1. DeepARG takes as input specifically nucleotide fasta out of PROKKA. Therefore if we don't run PROKKA on those samples that are supplied with the annotation fasta file, then those samples will not be executed by PROKKA. I.e. we would always have to run PROKKA on everything anyway regardless
  2. After thinking about it, I am also now concerned about version and software consistency. By allowing users supply their own FAA files, this could be from versions different from what we have in the pipeline, and in fact could be from different tools that may not be supported by other steps of our pipeline.

Therefore I would actually rather not support this. If you're concerned about speed, you could just Prodigal instead.

What do you think about this?

from funcscan.

jfy133 avatar jfy133 commented on August 15, 2024

Where I got to: 8bf973f

from funcscan.

jfy133 avatar jfy133 commented on August 15, 2024

I got an OK to skip this from Martin, and with the addition of Prodigal this should massively speed up the process anyway of those who are concerned about run time.

from funcscan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.