Giter VIP home page Giter VIP logo

Comments (11)

haxxproxx avatar haxxproxx commented on May 23, 2024

Added all requested features - waiting for feedback ;-)

from nfcgate.

malexmave avatar malexmave commented on May 23, 2024

Some Feedback:
App main screen

  • Are you using fixed sizes or relative sizes for the buttons and fields? Relative is probably better, as you can see here (empty space to the right of the buttons and fields). That would also fix the inconsistent sizes of the IP and Port fields.
  • What I forgot to mention: Where do we display the connection token the server generated for the session creator? In the "Session Status" window?
  • Theoretically, there should be a way to display text without using a read-only textarea for it. Would be a little more elegant across the board.

screenshot_2015-02-15-10-25-54

  • I think we just included the first two points of the dropdown panel to test the functionality. I think at least the "System settings" option can go away, as it is grossly confusing.
  • The NFC Settings option could also be removed and replaced with a check at startup "Is NFC enabled? No? Okay, give the user a popup with a button to get to the NFC settings". A little like Google Maps does if you try to navigate without GPS active.

Anyone else want to add further feedback?

from nfcgate.

haxxproxx avatar haxxproxx commented on May 23, 2024

Many thanks for the feedback! 👍

1.) Agreed - will use relative box/window/text-field sizes -> done
2.) Simply click on the "Join Session" button -> a popup dialog will appear :) -> see below
3.) Agreed - at least for the "please hold your device" text-field :) -> done
4.) Agreed - removing "System Settings" -> done
5.) Sounds like a feature request :) -> see #25

from nfcgate.

malexmave avatar malexmave commented on May 23, 2024

Point 2: That's where the connecting client can input his token. But the host (the device that starts the session) has to display the token somewhere so it can be shared with the partner, and that's what I was asking after :).

from nfcgate.

haxxproxx avatar haxxproxx commented on May 23, 2024

Well.. hmm ^^ Ok I'll just add another popup dialog showing the token after clicking on "create session"

from nfcgate.

malexmave avatar malexmave commented on May 23, 2024

We can also display it in the session status text box (i.e. Session Status: Connected (Session 928ff23)). That way, it remains visible.

from nfcgate.

haxxproxx avatar haxxproxx commented on May 23, 2024

Ok, at least keep it visible until the communication partner is properly connected

from nfcgate.

malexmave avatar malexmave commented on May 23, 2024

It's also possible, at least theoretically, for someone to leave a session and someone else to join the session afterwards (the server supports it). So it should probably be visible at least as long as a slot is open, and possibly for the full lifetime of the session.

from nfcgate.

haxxproxx avatar haxxproxx commented on May 23, 2024

Ok, didn't know that -> then it should be best to display the token permanently (for example in the status-box)

from nfcgate.

haxxproxx avatar haxxproxx commented on May 23, 2024

-> all updated accordingly

from nfcgate.

malexmave avatar malexmave commented on May 23, 2024

I think we have everything we need for this, so I'll close this issue for now. If something else comes up, I'll open a new one or talk to you directly.

from nfcgate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.