Comments (11)
Added all requested features - waiting for feedback ;-)
from nfcgate.
- Are you using fixed sizes or relative sizes for the buttons and fields? Relative is probably better, as you can see here (empty space to the right of the buttons and fields). That would also fix the inconsistent sizes of the IP and Port fields.
- What I forgot to mention: Where do we display the connection token the server generated for the session creator? In the "Session Status" window?
- Theoretically, there should be a way to display text without using a read-only textarea for it. Would be a little more elegant across the board.
- I think we just included the first two points of the dropdown panel to test the functionality. I think at least the "System settings" option can go away, as it is grossly confusing.
- The NFC Settings option could also be removed and replaced with a check at startup "Is NFC enabled? No? Okay, give the user a popup with a button to get to the NFC settings". A little like Google Maps does if you try to navigate without GPS active.
Anyone else want to add further feedback?
from nfcgate.
Many thanks for the feedback! 👍
1.) Agreed - will use relative box/window/text-field sizes -> done
2.) Simply click on the "Join Session" button -> a popup dialog will appear :) -> see below
3.) Agreed - at least for the "please hold your device" text-field :) -> done
4.) Agreed - removing "System Settings" -> done
5.) Sounds like a feature request :) -> see #25
from nfcgate.
Point 2: That's where the connecting client can input his token. But the host (the device that starts the session) has to display the token somewhere so it can be shared with the partner, and that's what I was asking after :).
from nfcgate.
Well.. hmm ^^ Ok I'll just add another popup dialog showing the token after clicking on "create session"
from nfcgate.
We can also display it in the session status text box (i.e. Session Status: Connected (Session 928ff23)
). That way, it remains visible.
from nfcgate.
Ok, at least keep it visible until the communication partner is properly connected
from nfcgate.
It's also possible, at least theoretically, for someone to leave a session and someone else to join the session afterwards (the server supports it). So it should probably be visible at least as long as a slot is open, and possibly for the full lifetime of the session.
from nfcgate.
Ok, didn't know that -> then it should be best to display the token permanently (for example in the status-box)
from nfcgate.
-> all updated accordingly
from nfcgate.
I think we have everything we need for this, so I'll close this issue for now. If something else comes up, I'll open a new one or talk to you directly.
from nfcgate.
Related Issues (20)
- warnning: xposed modules is not working properly HOT 6
- ChipToNFC: Relay & Sniffer HOT 9
- NFCGATE on WearOS NFC(HCE) SUPPORT HOT 3
- libnfc_nci error HOT 4
- [Feature Requests] HOT 8
- Include in NetHunter Store HOT 1
- Warning: Xposed module is not working properly HOT 15
- Add monochrome icon
- native hook doesn't work in xiaomi redmi note 11 pro+ HOT 8
- Native hook not available on Galaxy M31 (Magisk, Rooted, LSposed) HOT 14
- Building on m1 device HOT 1
- [Feature Request] We should be able to edit data
- [ Improvement ] Add support for Android14 HOT 5
- Native hook could not be found (some Samsung devices) HOT 41
- Native hook could not be found [Samsung SM-J730FM/DS] HOT 9
- Please rezolve with protobuf sync in server HOT 3
- The server is functional but does not transfer my data correctly!
- Cloning does not work (Galaxy S21 FE) HOT 11
- Native hook issues with SM-A526B HOT 5
- network.c2c.C2C.NFCData; is missing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nfcgate.