when a page is loaded via a https node-unblocker connection, the embed resources are still http about node-unblocker HOT 4 CLOSED

It's a browser security feature. I saw this one coming.

The fix is:

1. Make sure that all the urls have been successfully parsed.
2. Make sure that the parser recognizes that the user is accessing it via https and make the thisSite function to return https instead of http for the server url.

I don't use or have access to https at this time to test where in the request variable you would find if the connection went through https or not.

from node-unblocker.

Oh, yea, your absolutely right. I just didn't have time to fix it
yesterday, so I filed this to remind myself later.

Thanks,

• Nathan

Sent from mobile phone.
On Nov 28, 2013 3:30 AM, "Emil Hemdal" [email protected] wrote:

It's a browser security feature. I saw this one coming.

The fix is:

1. Make sure that all the urls have been successfully parsed.
2. Make sure that the parser recognizes that the user is accessing it via
   https and make the thisSite function to return https instead of http for
   the server url.

I don't use or have access to https at this time to test where in the
request variable you would find if the connection went through https or not.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-29446809
.

from node-unblocker.

(This used to work correctly - I'm not sure when it broke. That's part of
why I want more tests in place.)

Thanks,

• Nathan

Sent from mobile phone.
On Nov 28, 2013 8:11 AM, "Nathan Friedly" [email protected] wrote:

Oh, yea, your absolutely right. I just didn't have time to fix it
yesterday, so I filed this to remind myself later.

Thanks,

• Nathan

Sent from mobile phone.
On Nov 28, 2013 3:30 AM, "Emil Hemdal" [email protected] wrote:

It's a browser security feature. I saw this one coming.

The fix is:

1. Make sure that all the urls have been successfully parsed.
2. Make sure that the parser recognizes that the user is accessing it via
   https and make the thisSite function to return https instead of http for
   the server url.

I don't use or have access to https at this time to test where in the
request variable you would find if the connection went through https or not.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-29446809
.

from node-unblocker.

BTW, there was a much simpler fix for this: instead of prefixing all urls with http://proxysite.com/proxy or https://proxysite.com/proxy/, just use the /proxy/ part and let the browser figure out the domain and protocol :)

from node-unblocker.