Cookies not set properly in redirect about node-unblocker HOT 9 CLOSED

Good catch, do think you can fix it?
On Apr 23, 2014 8:11 AM, "Emil Hemdal" [email protected] wrote:

I created a test for this with PHP:

http://dev.ldbib.se/test/cookie_proxive_test.php
should redirect to
http://dev.ldbib.se/test/cookie_proxive_test2.php
and set a cookie named "hello" to "world"

Sourcecode to the tests:
http://dev.ldbib.se/test/cookie_proxive_test.txt
http://dev.ldbib.se/test/cookie_proxive_test2.txt

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30
.

from node-unblocker.

Working on it.

from node-unblocker.

I might have a working solution. I will test it further tomorrow.

from node-unblocker.

Cool, thanks!

On Thu, Apr 24, 2014 at 9:12 AM, Emil Hemdal [email protected]:

I might have a working solution. I will test it further tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-41277809
.

Nathan Friedly
Minister, JavaScript Ninjaneer
http://nfriedly.com

from node-unblocker.

See #31

from node-unblocker.

Ignore #31! Look at #32

from node-unblocker.

Hey, thanks, this is pretty close to perfect. We do need to make one change for your default cookie path though: it should default to the current directory, not /.

For example, a cookie set on /foo/bar.html should get a path of /foo/ if it's not specified in the set-cookie header.

See more info at http://tools.ietf.org/html/rfc2109#section-4.3.1

Also, you can make changes to your code after sending a pull request and they will still get included - a pull request just points to a branch, and I get the latest code in that branch whenever I merge it ;)

from node-unblocker.

@nfriedly,
I just had a look at it, and I think @emilhem latest PR (#32) actually does that.

https://github.com/emilhem/node-unblocker/blob/patch-2/lib/cookies.js#L108-111

if no path is present it defaults to: the pathname trimmed to the last slash

from node-unblocker.

Oh, right.. I forgot about that, thanks. I'll merge it in right now.

from node-unblocker.