Giter VIP home page Giter VIP logo

Comments (5)

nfriedly avatar nfriedly commented on July 3, 2024

I think this regex here just needs to be updated to also match URL=. Add a test or two and try that.

from node-unblocker.

nfriedly avatar nfriedly commented on July 3, 2024

Actually, that might not be right. This one should be matching absolute urls like that, so I'm not sure why it isn't...

from node-unblocker.

emilhem avatar emilhem commented on July 3, 2024

Yep, I tested that. It matches it but when I add a console.log in url-prefixer.js function rewriteUrls this is the response from the chunks before and after parsing:

<META HTTP-EQUIV="Refresh"

It doesn't parse the part after that it seems. Strange!

Alas, I think I found the missing part! In url-prefixer.js the flush function has a chunk remainder.

from node-unblocker.

emilhem avatar emilhem commented on July 3, 2024

When I change this to this.push(rewriteUrls(chunk_remainder, uri, config.prefix));. It solves the issue. The tests pass as well.

from node-unblocker.

emilhem avatar emilhem commented on July 3, 2024

My pull request #86 solves this issue.

from node-unblocker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.