Linting? about ng-bootstrap HOT 7 CLOSED

+1 for linting. But we need to re-shuffle our build first. IMO the current split of tasks between package.json and gulpfile doesn't make things clear / easy to evolve.

from ng-bootstrap.

I totally agree Pawel. Wes suggested dropping gulp and go fully webpack, which I totally agree. The problem is that I didn't see how to properly run clang via CLI (so I can do a npm script with that).

What do you think? Try to move more to package.json or move more to gulpfile?

Both have their good and bad parts.

from ng-bootstrap.

Wes suggested dropping gulp and go fully webpack, which I totally agree

I think that we need to have a conversation here :-) I'm fine with using webpack to prepare dist bundles, but I'm not sure it is the right fit for the entire build.

What do you think? Try to move more to package.json or move more to gulpfile?

My vote would go for gulp (probably starting with gulp 4 if we can)

from ng-bootstrap.

Oh, let me research the gulp 4 thing.

We need that conversation for sure. cough slack cough.

from ng-bootstrap.

I'm not hugely opinionated on the tooling, so I'm fine with keeping it mostly gulp.

I'm a big fan of linting though.

from ng-bootstrap.

With tooling in place, I will do this soon
El 9/11/2015 17:27, "Wesley Cho" [email protected] escribió:

I'm not hugely opinionated on the tooling, so I'm fine with keeping it
mostly gulp.

I'm a big fan of linting though.

—
Reply to this email directly or view it on GitHub
#63 (comment).

from ng-bootstrap.

Fixed by 8013e7b

from ng-bootstrap.