Discuss conventions: element vs. attribute selector about ng-bootstrap HOT 4 CLOSED

I don't think that it is more of a Directive or Component things.

If a component (as generic components, not @component) is meant to be a whole widget like an accordion, it is better to leave it as element:

<accordion>
  <group></group>
  <group></group>
  <group></group>
</accordion>

It would be weird to use it as attribute (I put it on our accordion because that existed in uibs)

On the other hand, if you have a component that is meant to modify a behavior, you should use attribute:

<input [(ng-model)]="date" ngb-datepicker-popup ...>

It doesn't make sense to use element in there.

from ng-bootstrap.

If a component (as generic components, not @component) is meant to be a whole widget like an accordion, it is better to leave it as element

Agreed. This is why I was wondering why you've decided to mark accordion as both an element and an attribute.

from ng-bootstrap.

First implementation was a bit straight from uibs to get my feet wet. I will file a PR.

from ng-bootstrap.

I think that this one is resolved.

from ng-bootstrap.