Necessity of VIRTUAL_HOST env variable about acme-companion HOT 6 CLOSED

Hi, no we can't remove VIRTUAL_HOST environment variable because it is use to configure nginx proxy and it is not used by this letsencrypt container.
If you don't have a VIRTUAL_HOST environment variable on your web container, the nginx proxy will not respond to requests for the domain.

from acme-companion.

@JrCs I know that VIRTUAL_HOST is used by the proxy-container and not by the letsencrypt container. But the letsencrypt container also modifies the nginx config. The location /.well-known/ { .. } part is from the letsencrypt container, isn't it?
So couldn't the letsencrypt container also create a virtual host on its own, if no VIRTUAL_HOST variable is defined? This would probably require some modifications to nginx.tmpl.

from acme-companion.

Yes the letsencrypt container add some configurations to the nginx proxy.
Yes we need to change the nginx.tmpl to get this case, and nginx.tmpl is a template from nginx-proxy.
I don't have a specific version of nginx.tmpl for this letsencrypt container. Each container use it's own environment variable (VIRTUAL_HOST for the docker-gen container and LETS_ENCRYPT_XXX for this container) and i don't want to mix all of them.
The nginx reverse proxy can be used with the docker-gen container without the letsencrypt container.
This container is just an add-ons to the nginx/docker-gen containers and it is not design to replace functionnality of one of them:

• nginx container do the reverse proxy
• docker-gen update the nginx proxy configuration when containers are create/remove
• letsencrypt-nginx-proxy-companion create letsencrypt certificats

from acme-companion.

@JrCs I understand. It's totally legitimate to keep things simple and compatible with the nginx.tmpl in jwilder/nginx-proxy 👍
Would you mind adding a LICENSE file to this project so I can fork it and support my specific use case?

from acme-companion.

@sherter ok i will add a LICENSE file done

from acme-companion.

Cool, thanks!

from acme-companion.