nodejs unit-http misses `options` in createServer function about unit HOT 2 CLOSED

Looks like the options argument was added in Node.js v9.6.0 (2018-02-22) / v8.12.0 (2018-09-11) in nodejs/node#15752 and we missed it when implementing our shim for http.createServer.

We should fix this in Unit, but the patch-package workaround should be fine for your use case until we can get a release out with a proper fix.

from unit.

I could create a fix by using patch-package with the following steps:

• Install unit-http and patch-package as npm dependencies: npm i unit-http patch-package --save
• Add "postinstall": "patch-package" under "scripts" inside package.json
• Edit the http.js file inside node_modules/unit-http by adding options as the first argument to the createServer function:

  function createServer (options, requestHandler) {
   return new Server(requestHandler);
  }
  

• Apply the patch: npx patch-package unit-http

As a current workaround this is ok. Although I think this might not be a sustainable approach. The options could be ignored in the case of our strapi deployment.

from unit.