Giter VIP home page Giter VIP logo

Comments (6)

hongzhidao avatar hongzhidao commented on August 30, 2024 1

Hi, our thoughts on it:

  1. Users can now use a config template to maintain the "environment" options.
  2. We agree it's more convenient to provide native variables for the application options like working_directory and environment. Now we are on the 1.32 version and we'll try it when we start the 1.33 version.

Thanks.

from unit.

lcrilly avatar lcrilly commented on August 30, 2024 1

If we consider that envsubst(1) and similar tools provides a reasonable workaround today, how useful would it be to "pass through" specific environment variables to the application's environment?

{
  "applications": {
    "foo": {
      "type": "external",
      "working_directory": "/path/to/thing",
      "executable": "app",
      "environment_passthrough": ["SOME_ENV_VAR", "OTHER_ENV_VAR"],
      "environment": {
        "HOME": "/path/to/thing"
      }
    }
  }
}

Would this be a worthwhile feature in its own right? Or is full access to env vars, across the entire configuration scope the main thing? If so, we might also consider environment variable substitution a function that the unitc CLI tool can provide.

from unit.

travisbell avatar travisbell commented on August 30, 2024 1

Yup, same here. Here's what one of our configs looks like and how we use ENV vars in our config:

"applications": {
    "sinatra": {
      "type": "ruby",
      "processes": {{ NUM_WORKERS }},
      "threads": {{ WORKER_THREADS_MAX }},
      "script": "{{ HOME }}/workspace/app/config.ru",
      "hooks": "{{ HOME }}/workspace/app/config/unit/hooks.rb",
      "working_directory": "{{ HOME}}/workspace/app/",
      "limits": {
        "timeout": 30
      }
    }
  }

from unit.

travisbell avatar travisbell commented on August 30, 2024

Oooooh, this is a good one. I use envtpl right now to get this functionality in my configs but would love to drop it as a dependency!

from unit.

hongzhidao avatar hongzhidao commented on August 30, 2024

Hi,
There are a few separate functions here.

  1. Unit supports variables and njs/JS for options like pass, share, etc.
    https://unit.nginx.org/scripting/
  2. It's able to access environment variables with njs.
    https://nginx.org/en/docs/njs/reference.html#process
  3. The variables and JS only work on the runtime phase.

But the option environment in the application is applied when the proto process starts, it's a different phase than the runtime phase which runs for the http request.

To make it short, the feature is about whether Unit provides variable engine in the application starting phase.
We'll discuss it with the team, and any thoughts are welcome.

from unit.

razvanphp avatar razvanphp commented on August 30, 2024

Our use-case would be to configure number of processes, options for applications (like memory_limit), etc. Thank you!

from unit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.