HttpParams not being parsed on http Post correctly about cashew HOT 9 CLOSED

I don't mind getting a PR that adds built-in support for it. If you can't, in the meantime, you can use a function to convert it.

from cashew.

Can you please reproduce it on stackblitz?

from cashew.

Replicated on SB: https://stackblitz.com/edit/angular-ivy-n6csyb?file=src%2Fapp%2Fhello.component.ts
Also occuring on A11

Using jsonplaceholder as a fake api service

from cashew.

Why you're not using a pojo?

    const params = {
      api_key: "1234",
      url: "https://google.com/"
    };

    this.http
      .get(
        "https://jsonplaceholder.typicode.com/todos/",
        withCache({ ...params })
      )

from cashew.

The HttpParam object is an output from another component. All the services were given HttpParams by default. If cashew doesn't have a native way to convert them, I can just create a function to change httpparam to an object.

Just wanted to check if I was missing something in cashew. If not, it's all good and we can close this out.

from cashew.

I also had some issues today when I used the library the first time.
I wanted to create a PR, but when I further investigated the issue, I found the solution to this problem (which is inside the application code) :

const  params = new HttpParams();
params = params.append('context', context)

// w/o cashew
// const options = {params};

// example above ("wrong approach"):
// const options = withCache({...params});

// with cashew ("right approach"):
const options = withCache({params});

this.http.get(url, options).subscribe();

I also adjusted the Stackblitz example, which is now working as expected: https://stackblitz.com/edit/angular-ivy-erpgym?devtoolsheight=33&file=src/app/hello.component.ts

from cashew.

Okay, nevermind my comment before.
Coming back to work topics, I need to see, that it is still not working correctly.

I recognized, that the request url to the api is not built correctly. This is what happens:
It builds a url in the format like this: <baseUrl>/api/v1/items?params=foo=bar&bar=foo

I don't know why, but it appends an additional params=. Without, everything would work fine

from cashew.

• wrong types in

export declare function withCache(params?: Params): {
    params: Params;
};

• in http.d.ts

get<T>(url: string, options?: {
        headers?: HttpHeaders | {
            [header: string]: string | string[];
        };
        observe?: 'body';
        params?: HttpParams | {
            [param: string]: string | string[];
        };
        reportProgress?: boolean;
        responseType?: 'json';
        withCredentials?: boolean;
    }): Observable<T>;

• So withCache should return type as http.d.ts, so If I can't add auth headers is not useful
• I think withCache should return HttpParams
• using angular 11

from cashew.

The library now uses context.

from cashew.