Comments (8)
nh2
commented on July 18, 2024
expected: ExitFailure 139
but got: ExitFailure 11
I've observed this before as well.
When we run it in the shell, we get exit code 139 (tried bash and zsh).
When running under strace, we get exit code 139.
But when running under hatrace, we get 11.
Relevant code is perhaps:
(newState, event) <- case status of
-- `Exited` means that the process chose to exit by itself,
-- as in calling `exit()` (as opposed to e.g. getting killed
-- by a signal).
Exited i -> do
case i of
0 -> pure (state, Death $ ExitSuccess)
_ -> pure (state, Death $ ExitFailure i)
Continued -> error $ "waitForTraceEvent: BUG: Continued status appeared even though WCONTINUE was not passed to waitpid"
-- Note that `Signaled` means that the process was *terminated*
-- by a signal.
-- Signals that come in without killing the process appear in
-- the `Stopped` case.
Signaled _sig -> pure (state, Death $ ExitFailure (fromIntegral fullStatus))Should check which of the two Death constructors is happening here.
from hatrace.
nh2
commented on July 18, 2024
For the third one, absence of clone() it may be an optimisation in newer bash.
On Ubuntu 16.04, in GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu), I get with strace:
% strace -fye clone,execve bash -c 'true && example-programs-build/hello-linux-x86_64'
execve("/bin/bash", ["bash", "-c", "true && example-programs-build/h"...], [/* 47 vars */]) = 0
clone(strace: Process 11440 attached
child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f43759f39d0) = 11440
[pid 11440] execve("example-programs-build/hello-linux-x86_64", ["example-programs-build/hello-lin"...], [/* 46 vars */]) = 0
Hello, world!
[pid 11440] +++ exited with 0 +++
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=11440, si_uid=1000, si_status=0, si_utime=0, si_stime=0} ---
+++ exited with 0 +++
While @qrilka gets:
On Gentoo, GNU bash, version 4.4.23(1)-release (x86_64-unknown-linux-gnu):
$ strace -fye clone,execve bash -c 'true && example-programs-build/hello-linux-x86_64'
execve("/home/qrilka/.nix-profile/bin/bash", ["bash", "-c", "true && example-programs-build/h"...], 0x7ffe60983030 /* 63 vars */) = 0
execve("example-programs-build/hello-linux-x86_64", ["example-programs-build/hello-lin"...], 0x720008 /* 63 vars */) = 0
Hello, world!
+++ exited with 0 +++
from hatrace.
nh2
commented on July 18, 2024
When trying with Bash 4.4.23 via nix on my Ubuntu, I also don't have the clone():
% strace -fye clone,execve /nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash -c 'true && example-programs-build/hello-linux-x86_64'
execve("/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash", ["/nix/store/czx8vkrb9jdgjyz8qfksh"..., "-c", "true && example-programs-build/h"...], [/* 47 vars */]) = 0
execve("example-programs-build/hello-linux-x86_64", ["example-programs-build/hello-lin"...], [/* 47 vars */]) = 0
Hello, world!
+++ exited with 0 +++
So that really looks like an optimisation, and the true && I put into that test to trick bash into actually making a clone syscall doesn't work any more in newer bash.
from hatrace.
nh2
commented on July 18, 2024
OK, we found the solution to this one: true && example-programs-build/hello-linux-x86_64 should be example-programs-build/hello-linux-x86_64 && true to force bash to clone(). I'll fix it.
from hatrace.
nh2
commented on July 18, 2024
For the second one, regarding the extraneous Syscall_rt_sigprocmask, we found that reverting commit 874b29c (fork_exec_with_ptrace: Use raise() instead of kill()) gets rid of it.
From man 3 raise:
SYNOPSIS
#include <signal.h>
int raise(int sig);
DESCRIPTION
The raise() function sends a signal to the calling process or thread. In a sin‐
gle-threaded program it is equivalent to
kill(getpid(), sig);
In a multithreaded program it is equivalent to
pthread_kill(pthread_self(), sig);
If the signal causes a handler to be called, raise() will return only after the
signal handler has returned.
This indicates that due to glibc differences between us, @qrilka's glibc does more (an extra rt_sigprocmask()) in raise().
My glibc version:
% ldd --version
ldd (Ubuntu GLIBC 2.23-0ubuntu11) 2.23
@qrilka's glibc version:
$ ldd --version
ldd (Gentoo 2.27-r6 p3) 2.27
from hatrace.
nh2
commented on July 18, 2024
Reverting the commit is the correct solution, as the extra handling for multi-threaded programs isn't necessary: We are just after fork() so there cannot be any other threads.
from hatrace.
qrilka
commented on July 18, 2024
Ending with b968ad1 all of this seem to get resolved
from hatrace.
nh2
commented on July 18, 2024
Yep, that should be the case.
Commits 877fae7 and 8cd9ec5 fix the exit code 11 vs 139 issue, though I still do not really understand what's going on (comment added).
The two commits above fix the other issues.
from hatrace.
Related Issues (15)
- Document OS compatibility HOT 3
- macOS compatibility
- Add syscall counting mode
- Print file paths for file descriptors
- Print executables for PIDs
- Filtering output on string buffer contents
- Building Issues HOT 3
- Improve parsing of program arguments
- procToArgv calls doesFileExist instead of checking for a slash
- Add analogue of --seccomp-bpf as a way to speed up syscall matching HOT 2
- ZuriHac 2020 project ideas
- Don't die on failing peekBytes
- Properly cleanup processes in case of conduit failing with an exception
- Improved dealing with bad pointers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hatrace.