Giter VIP home page Giter VIP logo

Comments (1)

nhaarman avatar nhaarman commented on June 20, 2024

Since most of the base implementations implement Savable* to allow easy state saving, this doesn't really allow intentionally not supporting state saving: the easiest of checks is whether the component implements Savable* and then actually calling saveInstanceState() on it.

Two solutions come to mind:

  • Include a property isStateSavable to the Savable* interfaces to indicate whether an implementation actually supports state saving. The interfaces can return true by default. This leads to some contradictive semantics though: A SavableScene that returns false for isStateSavable doesn't really make sense.

  • Don't let the base implementations actually implement Savable*, but do provide the saveInstanceState() implementation without overriding. Implementing classes can then just slap a Savable* on their class definition without having to override saveInstanceState():

abstract class StackNavigator(...) :  Navigator {
  /* ... */
  open fun saveInstanceState() : NavigatorState {
    return /* ... */
  }
}

class MyStackNavigator : StackNavigator(...), SavableNavigator {
  /* ... */
}

The latter doesn't really confidently provide a stable API however.

from acorn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.