Giter VIP home page Giter VIP logo

Comments (4)

nickjj avatar nickjj commented on July 24, 2024

Hi,

A number of folks have used this role as is on a pi3. What limitations are there with Ubuntu 20.04 on it? What about using Debian?

from ansible-docker.

sdwilsh avatar sdwilsh commented on July 24, 2024

I'm complicating my setup by netbooting with an iSCSI root, which I have not gotten to work in 20.04, but have with 20.10.

Regardless of that, I'm also a bit biased towards docker.io for reasons stated in this stackoverflow thread that say it far better than I can.

I'm happy to attempt a pull request on this, but I didn't want to put in the effort if it wasn't something you wanted to support.

from ansible-docker.

nickjj avatar nickjj commented on July 24, 2024

Docker still officially recommends installing Docker with docker-ce so I think it's best to stick with that standard by default.

You can also choose to only install the CLI with docker-ce-cli too, which I don't think is an option with docker.io. This role supports CLI only installations by setting ce-cli as the docker__edition.

I'm kind of reluctant to support 20.10 (or more generally non-LTS releases) because I have no experience using them, and I haven't had anyone ever request support for it. Most folks who use Ubuntu in production stick with LTS. There's also sometimes subtle differences with non-LTS releases that may require other changes in the future. That and Docker doesn't officially support installing itself on Ubuntu 20.10.

But with that said, I'm not opposed to supporting which package gets installed, such as docker__package and then you are free to choose docker-ce, docker-ce-cli, docker-ee, or docker.io but that's not a straight forward change because:

  1. It's a very backwards incompatible change that will break everyone's configuration if they customized docker__edition
  2. It would mean explicitly hard coding things like "if docker__package == docker.io then skip pulling in Docker's apt repos"
  3. If someone wanted to use docker-ce on 20.10, it's not going to work by default because I dynamically pull in the distro name when setting Docker's apt repo, but since Docker doesn't support "groovy" you'd have to go in and configure docker__apt_key_url and docker__apt_repository to hard code focal (technically supported but kind of hacky)

I wouldn't open a PR just yet because this would need careful planning and quite a bit of documentation to implement properly.

In the mean time you could fork this role and then make these 2 changes:

Hard code docker.io as the package name here:

name: "docker-{{ docker__edition }}"

Delete these lines:

- name: Add Docker's public GPG key to the APT keyring
apt_key:
id: "{{ docker__apt_key_id }}"
url: "{{ docker__apt_key_url }}"
- name: Configure Docker's upstream APT repository
apt_repository:
repo: "{{ docker__apt_repository }}"
update_cache: true
.

from ansible-docker.

nickjj avatar nickjj commented on July 24, 2024

I'm going to close this as it hasn't been brought up again for a few years. If it comes up again we can deal with it.

from ansible-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.