Comments (4)
Can you explain to me what broke for you? I have not tagged a release that includes #318 yet.
Here are some details that would be helpful:
- It sounds like you are depending on v1 of the library and not v2, is that correct?
- Are you using a tool like Go modules to version your dependencies?
- What version of Go are you using?
I suspect what might have actually broken you is that I deleted the go1
branch because I thought it wasn't necessary anymore but it might still be so I just recreated it. Are you still having an issue?
from go-i18n.
Maybe the concern is whether the library can still be imported with the /v2
suffix even though it doesn't correspond to a real directory in the repo.
from go-i18n.
Hello,
Thank for your support.
It sounds like you are depending on v1 of the library and not v2, is that correct?
Correct
Are you using a tool like Go modules to version your dependencies?
Yes, Go modules
What version of Go are you using?
Go 1.21
I suspect what might have actually broken you is that I deleted the go1 branch because I thought it wasn't necessary anymore but it might still be so I just recreated it. Are you still having an issue?
Currently, I have no problem. But if you remove v1 or if you plan to release a new version of v1 (for example with v1.11) with the v2. It will break all my code since v2 is not compatible with v1 (v1.10 and before).
from go-i18n.
v1 was removed from the main branch in 2019 so changes on on main should not impact v1. Any releases for v1 would happen on the v1
branch, but v1 is deprecated and unmaintained, so I don't expect new releases anyway. In any case, if you are using go modules to correctly pin to a v1 version, nothing should change for you.
The v2 subdirectory is not necessary for compatibility afaik. Popular projects like https://github.com/redis/go-redis, which is on v9, does not have a v9 directory. The v9 is just part of the name of the module as defined in the go.mod file. The only reason a v2 directory existed on this repo is because there was a period of time where both v1 and v2 co-existing on the main branch. This is no longer the case, so I think it is safe to clean up the v2 directory. If` you have evidence that this is unsafe, I am happy to reconsider.
Closing this issue since it seems like nothing is actually broken right now.
from go-i18n.
Related Issues (20)
- Is there are way to properly handle translation based on gender HOT 1
- Error handling is faulty HOT 3
- Setting the delimiters globally? HOT 2
- How to generate translations for the toml files HOT 3
- Upgrade golang.org/x/text v0.3.8 HOT 1
- `goi18n extract` doesn't seem to work for source file that use generics HOT 3
- Cound you export this function or when translation has error get the original value HOT 7
- Hook to commonly catch errors HOT 4
- Just a review
- Easy wrapper around this library HOT 1
- List fitting problem HOT 3
- merging new translation into existing translations omits the hashes
- [Question] Is there any way for reverse lookup in bundle? HOT 1
- Upgrade golang.org/x/text HOT 1
- Breaks on key description HOT 1
- Expose fields (or add access methods) of MessageNotFoundErr HOT 4
- Support template.Options for setting up missing key behavior HOT 2
- Can we add support of Tajik (TG) language HOT 3
- error `unsupported file format <nil>` when a yaml value is empty HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-i18n.