Comments (1)
Thanks for this refactor. I'm using it on a project.
I had an issue with this.panels = [ ...this.element.children ].filter( el => el.matches( panel.class ) );
which I changed to this.element.querySelectorAll( panel.class );
to look for all of the panels that are a child of the Tab container. Works for me!
from van11y-accessible-tab-panel-aria.
Related Issues (12)
- Add a destroy method HOT 1
- Turn tabs into accordions on small screens
- js-link-to-tab error: Cannot read property 'querySelectorAll' of null
- Link to another tab when different tab active
- Is there a way to prevent the browser from jumping down to the tab when a direct link has a tab hash in it?
- Active tab doesn't change using browser back/forward button.
- Contribution HOT 1
- Add data-attribute or class to open tab HOT 2
- tabs on screen size > x HOT 2
- data-selected doesn't seem to work HOT 3
- Invalid License Format HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from van11y-accessible-tab-panel-aria.