Giter VIP home page Giter VIP logo

Comments (4)

nicolaspanel avatar nicolaspanel commented on August 18, 2024

Definitely a bug. Thanks for for the issue, I will take a look ASAP.

from numjs.

huan avatar huan commented on August 18, 2024

I added some tests and played with it, but I still not made the trick.

diff --git a/src/ndarray.js b/src/ndarray.js
index 52c38d4..e4bf2f2 100644
--- a/src/ndarray.js
+++ b/src/ndarray.js
@@ -122,14 +122,14 @@ NdArray.prototype.slice = function () {
       step[i] = 1;
     } else {
       // assume it is an array
-      var start = (arg[0] < 0) ? arg[0] + tShape[i] : arg[0];
-      var end = (arg[1] < 0) ? arg[1] + tShape[i] : arg[1];
+      var start = (arg[0] < 0) ? arg[0] + tShape[i] + 1 : arg[0];
+      var end = arg[1] === null ? arg[0] < 0 ? 0 : tShape[i] : (arg[1] < 0) ? arg[1] + tShape[i] : arg[1];
       lo[i] = end ? start : 0;
       hi[i] = end ? end - start : start;
       step[i] = arg[2] || 1;
     }
   }
-

from numjs.

nicolaspanel avatar nicolaspanel commented on August 18, 2024

fixed in numjs#0.14.1

from numjs.

huan avatar huan commented on August 18, 2024

Awesome, thanks!

from numjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.