upnp functionality is used despite being config'd as False about nicotine-plus HOT 6 CLOSED

Yes I can move this line at the start of the function that's not a problem.
In this case we might have a look too at settingswindow.py at the end of the SetSettings function of the ServerFrame class.
What I'm trying to understand is what would break a Torify Nicotine+ ?
The line you're referring to 'upnp.IsPossible()' only checks if either the upnpc binary or python miniupnpc module is available and don't send any packet on the network as far as I know.

from nicotine-plus.

I've relocate the line at the top of the function OnFirstConnect() in frame.py.

I've also found another line to relocate in the upnp.py init function:

# Local LAN IP
self.internalipaddress = gethostbyname(gethostname())

This line was doing a NS lookup and i've pushed it back down to the function actually doing the port mapping so it's not called at initialization/check times. See https://github.com/gfarmerfr/nicotine-plus/commit/710621bc69ffb9179123bd94d0f5675996d0b208 in https://github.com/gfarmerfr/nicotine-plus/tree/avoid-unwanted-traffic-upnp

from nicotine-plus.

The error occurs when resolving the host name.

upnp = UPnPPortMapping() leading to the gethostbyname(gethostname()) is where the error occurs.

On windows, gaierror: [Errno 11003] getaddrinfo failed
On a Debian based machine, gaierror: [Errno -2] Name or service not known

I'll look into this further but the point remains that if someone doesn't want the upnp functionality for whatever reason, there is no need to be calling it at all.

from nicotine-plus.

Just posted a few seconds ago :)
Could you check my last post and tells me what do you think of the solution ?

from nicotine-plus.

Thank you, looks good.

from nicotine-plus.

Merged into master.

from nicotine-plus.