Giter VIP home page Giter VIP logo

Comments (9)

slook avatar slook commented on June 25, 2024

Cannot replicate on Linux (GTK3) using the reproducer steps provided.

What sort of crash is it silent or is there a Critical Error dialog with a stack trace?

from nicotine-plus.

metaisfacil avatar metaisfacil commented on June 25, 2024

Silent crash, nothing in debug logs. Turned all plugins off to retry and still occurs.

from nicotine-plus.

mathiascode avatar mathiascode commented on June 25, 2024

Does it only happen when filtering? What about other lists such as downloads/uploads, does Ctrl-C work fine there?

from nicotine-plus.

metaisfacil avatar metaisfacil commented on June 25, 2024

Hmm, I thought for sure it was only happening during filters, but on a secondary check Ctrl+C'ing files appears to be crashing even without a filter. Seems to also affect both uploads and downloads aside from searches.

To emphasize, Ctrl+C'ing folders does NOT crash the program.

from nicotine-plus.

mathiascode avatar mathiascode commented on June 25, 2024

Can you try the latest unstable build? I made some small clipboard-related changes. I can't get Nicotine+ to crash on my Windows 11 machine at least (don't have Windows 10 to test right now).

If it still crashes:

  • What is your system language set to?
  • Do you have any clipboard-related programs installed?
  • Does it crash after restarting Windows, when the clipboard is empty?
  • Do context menu items such as "Copy URL" result in a crash?

I could also prepare a build of Nicotine+ with console output enabled, to see if there's any useful information logged.

from nicotine-plus.

metaisfacil avatar metaisfacil commented on June 25, 2024

I installed this build. Copying files no longer crashes the program, however it's not copying the file name to clipboard, just "0". It now appears to be working properly, no idea why it was only copying "0" before.

  • System language is English (United States).
  • I do not have any programs dedicated to clipboard-related tasks installed. I have certain programs installed which have tools that can provide statistics about clipboard data, but this does not happen in the background. I can't think of anything that could interfere with Nicotine+ here.
  • I will check this later when I am in the position to do so.
  • "Copy URL" does not crash, they all work as expected.

from nicotine-plus.

mathiascode avatar mathiascode commented on June 25, 2024

I installed this build. Copying files no longer crashes the program,

Thanks for testing. Could you try this build (before the clipboard-related changes were made) and the newer build back-to-back, to confirm if the bug is actually fixed, or if it happened to go away temporarily.

however it's not copying the file name to clipboard, just "0". It now appears to be working properly, no idea why it was only copying "0" before.

"0" would be one of the empty numerical columns.

from nicotine-plus.

metaisfacil avatar metaisfacil commented on June 25, 2024

Alright, I've realized Ctrl+C will copy whichever specific part of the line was last clicked. I was not aware of this nuance, is it intended behavior? If I click on the filename, Ctrl+C copies the filename, if I click the music icon, Ctrl+C copies "audio-x-generic-symbolic", and previously if I clicked any blank areas under the "Folder" column to the left of the filename, Ctrl+C would cause the crash. I can't get the newer build to crash this way.

from nicotine-plus.

mathiascode avatar mathiascode commented on June 25, 2024

Alright, I've realized Ctrl+C will copy whichever specific part of the line was last clicked. I was not aware of this nuance, is it intended behavior?

That's intended. The exact value of the focused cell is copied. You can see which cell is focused by holding Alt, and move focus to another cell by either clicking it or using the arrow keys.

if I click the music icon, Ctrl+C copies "audio-x-generic-symbolic"

Thanks for mentioning this, it should now copy the tooltip text instead.

and previously if I clicked any blank areas under the "Folder" column to the left of the filename, Ctrl+C would cause the crash. I can't get the newer build to crash this way.

Ah, that would explain it. An empty string used to be copied to the clipboard, which must've caused a crash for some reason.

Since the crash no longer occurs, I'll close this issue. Let me know if you run into any other issues.

from nicotine-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.