Bitrate - Length - Speed about nicotine-plus HOT 12 CLOSED

Yeah I'll look at both issue probably this week-end.

from nicotine-plus.

For the search bitrate:

I noticed that too in 1.2.16 and 1.4.0. I've looked a little bit into it a few months ago but then I forget to come back to it. From what I remembered clients responding to the search request were sending these kind of informations (bitrate and length) in a non reliable manner. I mean, sometime the length was here but not the bitrate, sometime one of the two wasn't making any sense. I definitively need to take time to look into this.

For the speed:

It seems to not be indicated anywhere but it's in KB/s and it's an immediate speed. It seems to be calculated from the amount of data transferred between each GUI tick refresh (600ms) divide this interval of time. So when the transfer is completed at the beginning of one of these interval it would be divide by the total amount of time 600ms and result in a very small number at the last refresh of the downloaded file.

from nicotine-plus.

Yeah the bitrate and length thing is really annoying, I hope you'll be able to resolve it.

Well with newer faster broadband speeds now in MB/s it would be nice when you get time if they can be showing either KB/s or MB/s.

THANKS

from nicotine-plus.

Hi @Geyup,

I've a working implementation of the speed units being displayed in my repo 'develop' branch.
I'll look at the other part (length & bitrate in the search tab) soon.

from nicotine-plus.

Re @Geyup,

I've also added in the same branch a commit that try harder to find the bitrate and length of files in searches results.

Before this commit less than 10% of files had these infos, now it's more like 70%.
Some search results doesn't seems to give us any kind of infos other than the file size so I don't know how to have a better coverage for the time being. From what I've observed from the Qt client it seems to have the same behaviour: some clients don't report the extended attributes.

If you have time could you give a try to this branch and tell me if that seems good enough to you ?

from nicotine-plus.

Sounds good...

Well good enough for me, I don't think would be the issue, rather you being the developer, know the capability here better then me, of what to get, expect out of this...

I assumed every file you looked at would show this...

THANKS

from nicotine-plus.

Ok I grabbed from your repo and ran it...

I only saw around 10%- 20% of files showing the bitrate and length....

The Number showed 418 songs, so this percentage 10%- 20% I'd say is really low...

Hmm

from nicotine-plus.

Hi @Geyup,

Just to be sure you used my develop branch on my repo right ? Because these number looks to me more like the code in the master branch.

from nicotine-plus.

I cloned from here https://github.com/gfarmerfr/nicotine-plus.git

from nicotine-plus.

Ok and then you did a git checkout develop to switch to the develop branch right ?

from nicotine-plus.

My bad I didn't do git checkout develop...

After doing this now, and running nicotine, out of 500 files 100 didn't have info, so around 20% not showing...

It looks better but 20% does seem a high ratio, I hope this can be fixed so every file shows info, unless this is impossible, due to something on the end-users side, with a lack?

from nicotine-plus.

Yeah 80% coverage is more like it.
If you want to dig deeper you can compare with what SlskQt provide as answers but it seems to me that the problem is at the opposite end for some files. We just don't get all the needed metadata.
I'll push this branch in master and in the 1.4 branch for a future bugfix release.

from nicotine-plus.