Giter VIP home page Giter VIP logo

Comments (4)

nihalgonsalves avatar nihalgonsalves commented on June 2, 2024

Thanks for the report! I took a look, but am not sure what we should do with Safari TP. It's a floating target - right now that would mean an esbuild target of safari17, but that would be safari17.1 or so next month when Safari 17 is stable.

I could add a special case to not log an error and ignore it, but it wouldn't change the behaviour. What target would you expect from that query?

If it's just about the error, you could also change the query to add not safari TP: https://browsersl.ist/#q=last+3+Chrome+major+versions%2C%0Alast+3+Safari+major+versions%2C%0Aunreleased+Chrome+versions%2C%0Aunreleased+Safari+versions%2C%0Anot+safari+TP

This still returns 17, which is what Safari TP currently is, but avoids the floating TP version.

from esbuild-plugin-browserslist.

jroru avatar jroru commented on June 2, 2024

Thanks for looking into this!

What target would you expect from that query?

If this is my browserslist query in entirety:

  "unreleased Safari versions"

I believe esbuild-plugin-browserslist should resolve it to the esbuild target safari17.

I do not know how and when it should change to safari17.1, but I believe that it should.

I think Browserslist has made this difficult by resolving to safari TP rather than e.g. safari 17

from esbuild-plugin-browserslist.

jroru avatar jroru commented on June 2, 2024

If it's just about the error, you could also change the query to add not safari TP

In my case, I do explicitly wish to support unreleased Safari versions (TP)

from esbuild-plugin-browserslist.

nihalgonsalves avatar nihalgonsalves commented on June 2, 2024

In my case, I do explicitly wish to support unreleased Safari versions (TP)

Right, but if you use this query: https://browsersl.ist/#q=unreleased+Safari+versions%2C%0Anot+safari+TP you will still get a resolved target of safari17 and safari16.6 as of today, which is what you want, I think? Browserslist returns safari TP in addition to the future version numbers.

from esbuild-plugin-browserslist.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.