Upgrade to Browserify 5.x about karma-browserify HOT 12 CLOSED

We should probably wait until browserify 5.x stabilizes. At the moment this guy pushes 3 releases per day.

from karma-browserify.

It's stabilized a bit more now.

from karma-browserify.

Yup. There's an issue with transforms that I'm looking at now. Less daunting than expected though.

from karma-browserify.

I work a lot on browserify and plugins, so happy to look at sometime if you've got a test case.

from karma-browserify.

For some reason transforms aren't being run — can't figure out why for the life of me. It's not a module resolution issue. If you pass in a function directly it's never called.

from karma-browserify.

@terinjokes Please checkout the browserify-5-support branch. I started to work on some of the browserify 4.x -> 5.x conversion issues and the branch contains the current work in progress state.

A number of test cases fail (transforms ...). If you have time, try to get them green and we are ready to upgrade to browserify 5.

from karma-browserify.

The transform thing is driving me nuts. Can't for the life of me figure out why it's broken.

from karma-browserify.

Took care of transforms. Error handling is bizarre. This is bubbling up to the process:

https://github.com/substack/stream-splicer/blob/master/index.js#L131

It's not happening in a simplified example though

from karma-browserify.

Definitely a karma-bro bug and probably related to the way the bundle is deferred. Replacing util.defer(buildBundle, 1000) with buildBundle fixes the uncaught error event. It's then unhandled in https://github.com/Nikku/karma-bro/blob/browserify-5-support/lib/bro.js#L271

from karma-browserify.

@bendrucker I did some more work on the the branch.

I got all test cases green on a local development branch. Still the update behavior is absolutely broken and I need to find a way to fix that properly.

Updating the plug-in to work with browserify 5x is super hard. One problem is that browserify automagically builds bundles and reports errors (and assumes an error handler to be registered).
So there is no simple build-after all files have been added as in browserify 4.x.

I hope to find some more time to look into that this weekend.

from karma-browserify.

Sounds good. Will be curious to see what you've done thus far when you have a chance to push.

from karma-browserify.

Update the branch. Tests green but actual usage is still totally broken. Lets move the discussion to #18.

from karma-browserify.