Improve Webpack workflow about likely HOT 17 CLOSED

one of the source files requires a JSON file

It's an svg.json file with icons hash map. Maybe this should be a regular commonjs-module?

module.exports = {
  "facebook": "....",
  "twitter": "...",
};

Seems in this case webpack doesn't need any custom loaders, right?

from likely.

Yup, seems like an appropriate solution. Feel free to submit a PR if you’d like to :-)

from likely.

Wait, nope.

from likely.

What? :)

from likely.

Btw, if we have a webpack, why we need a browserify build? Maybe we need to switch to webpack anyway?

from likely.

Wait, nope.

I’ve thought that we’d still want to implement a UMD build in the future, but in fact there’s no need to do this until we have a real request. So, if you think you have time to switch Likely to Webpack, that’d be great because this’ll make us more flexible in the future. If you don’t, a simple svg.json → svg.js solution is OK.

from likely.

I think that there're two different problems:

• remove json to simplify current webpack flow
• get rid of browserify and keep use only webpack

If it's right, first of all, seems right to get rid of json file and then make a new issue about switching to webpack.

from likely.

Btw, if we have a webpack, why we need a browserify build?

Important: we don’t use webpack at the moment. Only Browserify.

If it's right, first of all, seems right to get rid of json file and then make a new issue about switching to webpack.

Yep, you’re right. I’ll create an issue about migration to Webpack.

from likely.

@vitkarpov, if you take this issue, please write back here so nobody else also takes it by an accident.

from likely.

Yep. I'll take it. Seems it's time to add me to the repo, so I can be assigned to issues :)

from likely.

Seems it's time to add me to the repo, so I can be assigned to issues :)

I’ll ask Ilya about this :-)

from likely.

I think we should merge update-reame first and then I'll update the webpack section.

from likely.

OK, I’ll let #45 hang out then until we merge #40.

from likely.

Okay. I'll make additional changes in #45 after that.

from likely.

@vitkarpov, you’re now a collaborator! I’ve assigned you to this issue.

from likely.

Thanks :) I can fix the readme now, #40 has been merged.

from likely.

Done

from likely.