Likely counters don’t always work properly when the buttons are added dynamically about likely HOT 8 CLOSED

@iamakulov

likely.initiate(article.querySelector('.likely'))

Actually, this doesn't make sense. likely.initiate initiates all buttons on the page, and accepts options, not a link to node.

Instead of, seems likely(article.querySelector('.likely')) is the proper way, assuming article.querySelector('.likely') returns single node inside a new article, exactly the node where likely should be initialized.

However, the code likely.initiate() actually finds all new widgets, and updates an old ones. So apparently there's a problem with updating existing widget.

I'll try to find the latter out, and Tinkoff's guys can change likely.initiate to just likely(node), `cause it's the right way anyway.

from likely.

I’ve asked folks to replace likely.initate(node) with likely.initiate(), this didn’t help. So yep, looks like an issue in our code.

I'll try to find the latter out, and Tinkoff's guys can change likely.initiate to just likely(node), `cause it's the right way anyway.

Good option, will suggest. Thank you!

from likely.

likely.initate(node) with likely.initiate()

yep, as this didn't change anything we have a bug with updating existing widgets

from likely.

Reproduced the following case:

• load the test page
• perform likely.initiate() in console
• counters vanished

I think this should be separated into its issue

from likely.

#83

from likely.

@iamakulov as #83 will be fixed, I believe fellows can perform likely.initiate, as they already do: the new widgets should be initialized and the old ones be not broken.

from likely.

Wow, the reproduced case seems to be related to #75, I’ve seen something similar there. Probably it’s even a single bug.

from likely.

Closed in #84.

from likely.