Comments (3)
While looking at the code, I have found out that there are two issues basically.
In joinPath(".", "a")
and similar cases, the path becomes "."
after first addNormalizePath
and second addNormalizePath
doesn't remove it. In test cases this one is called "controversial" because of how paths to executables behave on Unix systems:
Lines 590 to 594 in 0b5a938
Retaining this behavior might be good to prevent older programs from breaking, but it starts to look much weirder in case of
joinPath("b", "..", "a")
or joinPath(".", "..")
, so probably worth either fixing or documenting.
The second part is less controversial and more looks like a bug. The problem is in the line
Line 75 in 0b5a938
This is not the correct way to check if it's the first component of the path, as
state == 0
holds also for such paths as .
or ../..
. Thus, when handling joinPath("x/..", "/a", "/b", "../../..")
it starts to think at some point that the path is absolute, because it receives "/"
from PathIter
. Though, by coincidence and only because the .
is not removed because of the first issue, it seems that such incorrect state doesn't lead to wrong results (or at least I haven't been able to found the failing case).from nim.
But ./a
is not the same as a
. 🤔
from nim.
But ./a is not the same as a. 🤔
Well, but
import std/[os, paths]
echo normalizedPath("./a")
echo "./a".Path == "a".Path
prints
a
true
And the documentation promises that joinPath
Nim/lib/std/private/ospaths2.nim
Lines 96 to 98 in 0b5a938
but
./a
is obviously not normalized.from nim.
Related Issues (20)
- SIGSEGV with object variants and RTTI HOT 10
- Bug in C++ codegen for set stringify when setting size HOT 5
- Support `jobserver` when parallelising builds
- On Linux, "nimsuggest" crashes if Nim is installed in /usr/bin and the library in /usr/lib/nim HOT 6
- dom addEventListener has ambiguous types HOT 1
- SigAction isn't missing a field on amd64? HOT 28
- Some C struct can have nested union. This is not supported for now HOT 7
- [Semi-regression] C code contains backtick`gensym HOT 1
- `hasCustomPragma` does not work on generic types HOT 1
- Rasing an exception leaks memeory in `orc` HOT 1
- Seq IndexDefect leaks memeory in `arc` and `orc`
- https://learnxinyminutes.com/docs/nim/ error in the learning documentation code HOT 3
- `noinit` can cause arc to crash with ref objects HOT 2
- hello world Mummy web server crashes on devel HOT 17
- Sigsegv on std/tasks destructor HOT 2
- `=destroy` for non-var failed to compile when `nim doc` HOT 4
- regression from 2.0.4 to 2.0.6 cannot instantiate: 'SomeInteger' in return type HOT 1
- Deadloop in Windows, `os.sleep(-1)` HOT 5
- Deadloop in Windows, `os.sleep(-1)` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nim.