Comments (5)
fqj1994
commented on September 2, 2024
It looks server_name_indication is a client-only option in erlang OTP's ssl module.
Could you please just add client-side SNI option thanks.
from ranch.
essen
commented on September 2, 2024
Hey, sure we can add options, but I'm not sure what you want exactly. Best is if you can make a PR adding the exact options. You can use this one as an example: https://github.com/ninenines/ranch/pull/77/files
Failing that please at least give the exact options.
from ranch.
fqj1994
commented on September 2, 2024
Hello,
I just submited a PR to erlang/otp about SNI server support. I don't know whether it will be accepted.
I'll wait for several days (maybe longer) to submit PR to ranch as the content of the PR may change depending on whether the PR to erlang/otp is accepted.
AndSNI client option is not urgent as erlang's ssl module can handle it automatically if the host you're connecting is written in hostname rather than ip address.
from ranch.
essen
commented on September 2, 2024
Yep I saw. No worries about the PR, I'll keep it open as long as needed. For future reference this is the PR: erlang/otp#574
Thanks!
from ranch.
essen
commented on September 2, 2024
Done in 0d5d855. Thanks!
from ranch.
Related Issues (20)
- Supervisor protocol process cannot be stopped when connection is closed (connection_type=supervisor). HOT 15
- Upgrading from 1.4 to 2.0 HOT 5
- Release Ranch 1.8 that is compatible with OTP-24 HOT 15
- Ranch 1.7, issues upgrading a tcp to ssl/tls connection HOT 7
- Add hex metadata to Ranch master HOT 1
- Add a function that converts from ProxyInfo to ssl:connection_information/1 return value HOT 2
- using gen_tcp new interface inet_backend socket cann't listen multiple sockets in one port HOT 6
- remove the socket file before the listen and change_mode the socket file right after listen HOT 14
- Update appup for 2.1.0 HOT 3
- Proxy protocol unique ID TLV type HOT 1
- The user guide links on the README are broken HOT 1
- Password should be blanked instead of logged on error HOT 1
- TLS 1.3 connection with client verification always successful HOT 1
- ranch:handshake(Ref) silently drops invalid TLS connections in ranch_ssl via exit(normal) HOT 17
- Questions about "gen_tcp:accept/2" and "num_acceptors" HOT 2
- ranch:stop_listener/1 throws error HOT 2
- {error, no_cert} with `certs_keys` from OTP 25 HOT 8
- Issue when using DTLS HOT 6
- Minor: ranch_ssl:listen can return non-atom error reasons HOT 2
- Restart issues found when upgrading 1.8 -> 2.1.0 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ranch.