It looks like runnig multiple instances of same process with <code class="notranslate"

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

IntermediateCatchEvent does not work with multiple running instances about lib-bpmn-engine HOT 2 CLOSED

blib commented on July 24, 2024 1

IntermediateCatchEvent does not work with multiple running instances

from lib-bpmn-engine.

Comments (2)

nitram509 commented on July 24, 2024

@blib thank you for providing this test case and good catch 👍

May Ia ask, in the test you wrote bpmnEngine.PublishEventForInstance(pi1.GetInstanceKey(), "globalMsgRef", nil) twice,
and the assertions as well. It seems redundant and could be shortenened, like below.
Do I oversee something?

PS: I will provide a fix soon.

func Test_IntermediateCatchEvent_multiple_instances_received_message_completes_the_instance(t *testing.T) {
	// setup
	bpmnEngine := New()

	// given
	process, _ := bpmnEngine.LoadFromFile("../../test-cases/message-intermediate-catch-event.bpmn")
	pi1, _ := bpmnEngine.CreateAndRunInstance(process.ProcessKey, map[string]interface{}{"key": "pi1"})
	pi2, _ := bpmnEngine.CreateAndRunInstance(process.ProcessKey, map[string]interface{}{"key": "pi2"})

	// when
	bpmnEngine.PublishEventForInstance(pi1.GetInstanceKey(), "globalMsgRef", nil)
	bpmnEngine.RunOrContinueInstance(pi1.GetInstanceKey())
	bpmnEngine.RunOrContinueInstance(pi2.GetInstanceKey())

	// then
	then.AssertThat(t, pi1.GetState(), is.EqualTo(Completed))
	then.AssertThat(t, pi2.GetState(), is.EqualTo(Active))

	// when
	bpmnEngine.PublishEventForInstance(pi2.GetInstanceKey(), "globalMsgRef", nil)
	bpmnEngine.RunOrContinueInstance(pi1.GetInstanceKey())
	bpmnEngine.RunOrContinueInstance(pi2.GetInstanceKey())

	// then
	then.AssertThat(t, pi1.GetState(), is.EqualTo(Completed))
	then.AssertThat(t, pi2.GetState(), is.EqualTo(Completed))
}