Initial review feedback about nitrokey-websmartcard-rust HOT 2 OPEN

Some of the listed points are fixed in #3
Regarding the questions:

1. Instead of peek, parsing the Credential's key type could work better, at a potential compatibility problems cost (browser validating and rejecting the requests).
2. git-version is good for the development stage, so you do not need to bump version by hand constantly. Why do you think this is a problem? For the actual release this would not be required of course.
3. OpenPGP stuff was all working at the time - you can check test reports.
4. Passing traffic to opcard-rs would be cool to have. It was not ready back when this was worked on. Though right now it cannot be done by design, is it not that right? Also, I would be vary opening it to the Web applications. As for the actual keys, that would have to be decided by the user (separate set, or the same, or even connecting that with multiple identities feature).

For the context of some of the listed points, this implementation was a haste transcription from C, having as much same elements as possible to keep the compatibility with the related applications.

from nitrokey-websmartcard-rust.

I do not understand what you mean by "parsing the credential's key type could work better".

from nitrokey-websmartcard-rust.