Order-dependent commands about disko HOT 5 CLOSED

The issue we encounter here is that nix attrsets are always sorted by name. I think would need to make this a list instead just like this is done for partitions?

from disko.

ah, I would just create lvs with 100%FREE size as last. that should fix the issue?

from disko.

@Mic92 I assume that mapping things to a list would not perform automatic sorting? If that's the case then I think it should work.

@Lassulus do you mean internally treating every 100%FREE entry as special and "manually" processing those last when resolving them? I think that would also work if it can be done reliably. I can't imagine a case where there's a 100%FREE entry that is not last, unless of course it's the only entry, in which case it is also the last one. I would imagine this applies to more than just LVS though.

from disko.

@a-dma can you check if my PR solves the issue? We could also think about a general solution but special solutions like that should also be useful.

from disko.

I see the PR has been merged already, so I tested master. Happy to report that it worked for me. Thanks!

The only other thing that I had to do to get my own setup to work was to manually set a label on the swap partition given that there is no extraArgs for that type. But that's unrelated and perhaps something that should go into another issue.

Thanks again for the help, closing this.

Resolved via #234.

from disko.