error: attribute 'disks' missing about disko HOT 5 CLOSED

hey thank you. The error is in how you integrate your disko-file into your configuration I guess. do you just use imports = [ ./disko-file ]; ?

from disko.

ah, so the problem is disks is not in specialArgs and the nixos import functionality then tries to find disks in specialArgs and gives up if it's not there. sadly this is one of the points where nixos modules are not lazy.

for a better solution (although I haven't tested that yet) I would suggest creating an option or harcoding the device in the disko config without that fancy arg stuff (which I only introduced because the tests needed it this way, but it's basically gone in my big refactor here: #294)

if you want to try out the options method, do something like this:

{ config, lib, ... }: {
  options.disks = lib.mkOption {
    type = lib.types.listOf lib.types.str;
    default = [ "/dev/disk/by-id/nvme-Samsung_SSD_960_EVO_1TB_XXXXXXXXXXXXXXX" ];
  };
  disko.devices = {
    disk.nvme = {
      type = "disk";
      device = builtins.elemAt config.disks 0;
      content = {
      .... same as before ....

you can then override that anywhere in your nixos configuration with

disks = [ "/dev/someotherdev" ];

but if you don't really want to change disks at some point, you can just hardcode it by changing your config into this:

{ 
  disko.devices = {
    disk.nvme = {
      type = "disk";
      device = "/dev/disk/by-id/nvme-Samsung_SSD_960_EVO_1TB_XXXXXXXXXXXXXXX";
      content = {
      .... same as before ....

hopefully that made it clear, if you have more questions, feel free to ask here :)

from disko.

Wow, thank you for coming back so fast. In fact I use it as a module (freely adapted from Setting up my machines: nix style. Here is my complete configuration: nix-it-up.

from disko.

sadly the module method breaks the cli args method, I still to find a better way in the CLI for that :) but maybe I rewrite the CLI to just use a nixos config and then it extracts the create and mount scripts from there.

from disko.

Thank you very much. I tried the first solution just out of curiosity, but it threw an error, so I went with the easy (hardcoded, disk-specific) way. Maybe I have try the harder way, when I need it with another machine.

Thank you for fixing this.

from disko.