Incompatibility of `nixosModules.hardware-amazon` with disko configuration about disko HOT 4 OPEN

A fix for digitalocean is here: NixOS/nixpkgs#297640
I think all nixos modules should use lib.mkDefault to allow for different downstream disk layouts.

from disko.

I have a similar problem importing nixos/modules/virtualisation/digital-ocean-config.nix while using disko. I workaround this using:

  fileSystems."/" = {
    device = lib.mkForce "/dev/disk/by-partlabel/disk-main-root";
  };
  boot.loader.grub.device = lib.mkForce "/dev/vda";
  boot.loader.grub.devices = lib.mkForce [ "/dev/vda" ];

from disko.

I moved the issue as this is a compatibility problem between disko and the NixOS profiles that ship with nixpkgs.

I'm not sure what's the best.

Is disko supposed to control the whole fileSystems prefix and override all the values? Or should the upstream profiles be setting their values using lib.mkDefault (or some other idea I didn't think about) ?

from disko.

Is disko supposed to control the whole fileSystems prefix and override all the values?

That would be an issue for systems which use disko for provisioning the base os but later on add pet mounts (i.e. a zfs data pool).

from disko.