Giter VIP home page Giter VIP logo

Comments (1)

TheRealGramdalf avatar TheRealGramdalf commented on September 22, 2024 1
  • datasets.*.mountpoint
  • This sets a "legacy" mountpoint, aka the fstab. Typical ZFS installations instead use the mountpoint property (see the next point)
  • datasets.*.options.mountpoint
  • This sets the respective zfsprop - the native feature used by ZFS to automatically mount datasets independently of fstab (typically via a systemd service that grabs information from the datasets and mounts it). datasets.*.options.* can actually be used to set any zfsprop - compression, encryption, or even custom user-specified ones like com.sun:auto-snapshot (which is used in second party tooling outside of ZFS, in this case some sort of sun microsystems thing).
  • datasets.*.content.mountpoint
  • This isn't actually valid - I believe you're referring to disko.devices.<devicename>.content.partitions.<partname>.content.mountpoint, not disko.devices.zpool.<zpoolname>.datasets.<datasetname>.content.mountpoint. In actuality it doesn't really matter - since neither are valid in the context - the former is only valid if disko.devices.<devicename>.content.partitions.<partname>.type is NOT zfs.
    • It essentially boils down to ambiguous wording - disko.devices.zpool is used to define the contents inside a zfs pool - datasets, zfs volumes, and their respective properties - whereas disko.devices.<devicename>... defines the physical layout of the zfs pool as a whole (what disks to use, whether to use an entire disk or a single partition etc). Disko further abstracts upon this by adding in custom glue in the form of mountpoint.
    • In my mind the best solution would be to rename mountpoint to something like fstabEntry to disambiguate the two - mountpoint is generic and has it's own special meaning in various contexts. One alternative (or additional?) solution would be to rename ...<datasetname>.options to ...<datasetname>.properties/zfsprops, since that aligns closer to the upstream implementation.

Edit:
Further confusion comes because in order to use an fstab entry to mount a zfs dataset, you need to set the zfsprop mountpoint=legacy for it to work properly.

p.s. I realize that changing an option name isn't ideal, but it's not unheard of, and is in my opinion better to do sooner rather than later, in case disko sees more widespread adoption and it becomes even more cemented. Part of the problem is also the lack of easily readable docs, so some of this concern may be invalid once those are available (though I personally prefer explicit configuration rather than ambiguous configuration).

from disko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.