Giter VIP home page Giter VIP logo

Comments (7)

adisbladis avatar adisbladis commented on June 25, 2024 1

Fixed! We're now hosting it :)

from infra.

ryantm avatar ryantm commented on June 25, 2024

You'll need to have a GitHub token secret, right? For that, you'll need to have a GPG key with git-crypt. Also, all the current people who have access to the secrets will need to be okay with you having access.

I am okay with you having access.

Then, you will need to make a PR that adds NixOS configuration for running your bot.

from infra.

timokau avatar timokau commented on June 25, 2024

Sounds good!

It's built as a GitHub App now, so it will need

  • a gpg private key generated by GitHub (this is then used to derive a JWT which is in turn used to ask github for an ephemeral installation token...)
  • a webhook secret to make sure the bot only reacts to the real webhook events and
  • I think the GH App ID is not public information either, so it can't hurt to treat that as a secret as well.

I haven't used git crypt before. So that would basically mean that someone with an already whitelisted key would add my gpg public key to the whitelist?

Since the secrets should only be a one-time setup, I'd be okay with just letting one of the pre-existing admins set that up if that is easier.

from infra.

ryantm avatar ryantm commented on June 25, 2024

You also need access to the secrets to deploy to the server. If you don't care about that, I can add your secrets for you.

from infra.

timokau avatar timokau commented on June 25, 2024

Ah, I assumed it just deploys directly from github's master. Being able to deploy fixed might be useful, but I could also live without that since there are already 6 admins.

I created #25 to get started with the configuration part. I modeled it after your nixpkgs-update config.

from infra.

timokau avatar timokau commented on June 25, 2024

Also, all the current people who have access to the secrets will need to be okay with you having access.

Should I open an issue about this? Having to nag one of you every time I'd like to deploy an update is not ideal, especially since I can't control when a deploy happens :)

from infra.

ryantm avatar ryantm commented on June 25, 2024

Yes, it's probably best to open another issue, then I can ping all the people with access to get their okay.

from infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.