Giter VIP home page Giter VIP logo

Comments (4)

inclyc avatar inclyc commented on September 22, 2024 1

we have non-garbage character level position information for about 90% of nixos options available under options.OPTION.declarationPositions, in the format of unsafeGetAttrPos.

I just carefully read your PR looks like we can have line & column information by eval declarationPositions, and might be a preferred way to answer LSP requests.

This could, at least theoretically, form the basis of goto definition on nixos options. I expect this may have similar challenges to implement as #174,

The real challenge about options is, we cannot easily find out the attrpath where the user clicked. For now we have a slightly modified parser on the main branch, but that discards necessary information after parsing (that's why we have #257 and cannot be trivially merged).

from nixd.

inclyc avatar inclyc commented on September 22, 2024

This is already implemented in #93 ?

from nixd.

lf- avatar lf- commented on September 22, 2024

Yes, you're right; I missed that one. I think you may be able to use the declarationPositions attribute for a more direct way of getting to the attribute location which would be more reliable in certain cases (but falls over in different cases).

from nixd.

inclyc avatar inclyc commented on September 22, 2024

This feature gets implemented in #433.

@lf-

from nixd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.