Giter VIP home page Giter VIP logo

Comments (12)

nviennot avatar nviennot commented on June 3, 2024

I can't reproduce this bug.

I pushed a fix to prevent namespace issues: c9d05fa

Let me know if that makes any difference.


Btw, this should make you happy: http://nobrainer.io/docs/3rd_party_integration/

from nobrainer.

jakcharlton avatar jakcharlton commented on June 3, 2024

Unfortunately switching to the latest commit causes two config options to be out of date (deleted, wasn't using) ... more importantly gives me:

No database specified in rethinkdb://localhost

For my config of config.rethinkdb_url = "rethinkdb://localhost"

My config is correct, I don't want a database on the URL - it's specified by the code

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

You can set something like rethinkdb://localhost/nothingtoseehere.
NoBrainer needs a default database to work with.
If your code is correct and always specify a database, the nothingtoseehere database should never get used/created.

from nobrainer.

jakcharlton avatar jakcharlton commented on June 3, 2024

What does it use a default database for then?

On Mon, Jan 6, 2014 at 5:52 PM, Nicolas Viennot [email protected]:

You can set something like rethinkdb://localhost/nothingtoseehere.
NoBrainer needs a default database to work with.
If your code is correct and always specify a database, the
nothingtoseehere database should never get used/created.


Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-31630573
.

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

NoBrainer has no way to know that you will always specify a database in all consistences

from nobrainer.

jakcharlton avatar jakcharlton commented on June 3, 2024

Then it should throw when you try to use one that you haven't specified...
not use a default database that doesn't or shouldn't exist

On Mon, Jan 6, 2014 at 5:56 PM, Nicolas Viennot [email protected]:

NoBrainer has no way to know that you will always specify a database in
all consistences


Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-31630706
.

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

I don't think that's a good idea, the rethinkdb driver will assume the database to be test if left unspecified: http://www.rethinkdb.com/api/ruby/connect/

from nobrainer.

jakcharlton avatar jakcharlton commented on June 3, 2024

Then I suggest you leave it as 'test' ... again principle of least surprise

  • anyone reading the RethinkDB docs will expect it to be test. It is better
    to be consistent with other Rethink apps, than to take a third path that
    neither Rails nor Rethink would do with other databases or platforms

Its not realistic expect to be online anytime someone hits an undocumented
problem to explain it, rather than them just figure out what would normally
be the behaviour

On Mon, Jan 6, 2014 at 6:06 PM, Nicolas Viennot [email protected]:

I don't think that's a good idea, the rethinkdb driver will assume the
database to be test if left unspecified:
http://www.rethinkdb.com/api/ruby/connect/


Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-31630996
.

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

You can also disable the database auto creation, which will prevent the use of a non expected database.

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

The normal behavior is to manually invoking connect. With NoBrainer, this connect becomes automatic, hence the problem.
I think that using the test database by default can create issues that are hard to debug. Better be safe than sorry.

from nobrainer.

jakcharlton avatar jakcharlton commented on June 3, 2024

But in your current version ... I would get bugs placing data in my
'default' database ... which is no less easy to debug than 'test' and
possibly way harder to debug as it might actually be a valid database
containing other valid data

Anyway - the stack overflow is fixed cheers

On Mon, Jan 6, 2014 at 6:17 PM, Nicolas Viennot [email protected]:

The normal behavior is to manually invoking connect. With NoBrainer, this
connect becomes automatic, hence the problem.
I think that using the test database by default can create issues that
are hard to debug. Better be safe than sorry.


Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-31631301
.

from nobrainer.

nviennot avatar nviennot commented on June 3, 2024

I suggest that you turn off automatic database creation with config.auto_create_databases = false to avoid such issues.

Good to hear that the stack overflow is gone :)

from nobrainer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.