Giter VIP home page Giter VIP logo

Comments (7)

emyann avatar emyann commented on August 26, 2024

@SamuelColacchia Thank you for using Morphism and bringing this feature on the table. I was thinking about having an async interface on Morphism for several purposes (parallelization, async transformations...). It might be a good start.

My first thought was to have an .async property available on morphism like:

const customerSchema = {
  firstname: "firstname",
  lastname: "lastname",
  email: "email",
  group: {
    path: "group",
    fn: async value => {
      const res = await callSomeService(value);
      return res.data;
    }
  }
};

const result = await morphism.async(customerSchema, input)
// ==>
// {
//   "firstname": "somefirstname",
//   "lastname": "somelastname",
//   "email": "[email protected]",
//   "group": "somegroup"
// }

Mostly to keep the backward compatibility on the synchronous interface and provide the appropriate typing with TypeScript.

What do you think about this implementation ?

from morphism.

SamuelColacchia avatar SamuelColacchia commented on August 26, 2024

@emyann That seems like it would be a good solution to the problem. Thinking it over in my head it would require the caller of morphism to explicitly want to wait for a async request, which I think is a good approach.

from morphism.

emyann avatar emyann commented on August 26, 2024

@SamuelColacchia Awesome! Thank you for your feedback, I'm going to schedule this feature on the next branch as a beta feature. I'll get back to you for testing purposes if you're ok with it :)

from morphism.

SamuelColacchia avatar SamuelColacchia commented on August 26, 2024

@emyann Sounds good to me.

from morphism.

kirsar avatar kirsar commented on August 26, 2024

@emyann Hi, thanks for the library, it's nice and compact! How does the feature live? :)

from morphism.

emyann avatar emyann commented on August 26, 2024

@kirsar Thank you for the feedback! I'm actively working on a big chunk of the library which is Data Validation that should land soon on the beta branch (https://github.com/nobrainr/morphism/releases)

Working on that make me realize that I needed to support async validations also, so I'm ideating this async part of morphism but I do want to have a clear separation between side effects and the actions of transforming the data itself, that in my opinion should stay as pure as possible.

I'll likely come up by the end of this month with a design on how I envision this in Morphism, and in the meantime I would love to hear about your use-case with that feature if you're interested 🙂

from morphism.

kirsar avatar kirsar commented on August 26, 2024

Thanks for reply.
My case is very simple: I need to talk with 3rd party via some amqp and use morphism to map 'my' entities to 'their' commands / events.
And I want to separate mapping config (schema) away from other complexity, but sometimes I need to make async calls to db to reconstruct entity from event (3rd party is not under my control), like:

{
    id: 'id',
    stateId: event => (await stateRepo.getByCode(event.state)).id,
}

from morphism.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.