Comments (3)
Yeah, the basic workaround would be to handle insert
specially or more generally look at all keymap and state aliases. I'm okay with that, but maybe the current check should be completely changed. It won't work in other cases too (the key definer function might not yet be defined when the check happens). Maybe there needs to be a specific list of definers to check against that can be automatically populated by general-create-definer
at expansion time. That would probably be more inconvenient if someone was using custom definers not created with general-create-definer
though. I'll have to think about the best way to handle this. Probably I'll just check against aliases first and then add a note to the readme that custom definers need to be available at expansion time with an example for a compiled init.
from general.el.
Maybe we can use symbol properties? So that general-create-definer
automatically sets the property on the definer symbol, and anyone using an unsupported setup can do so manually.
from general.el.
It might cause some issues for people when updating general.el (maybe the new behavior should be opt-in for a while), but I think that's the correct way to handle it.
from general.el.
Related Issues (20)
- Add an option to disable autoloading a command in `use-package` integration HOT 1
- Key sequence starts with non-prefix key. HOT 2
- Leader key only works in messages buffer after changing modes (EVIL) HOT 4
- Overriding mapping in minor modes HOT 3
- Rewrite HOT 16
- having seeing latex keys in org mode HOT 1
- How to pass a command list to `general-define-key` HOT 1
- Optimizing for speed: do's and don'ts HOT 9
- Prefix is not working with local leader definer HOT 1
- which-key labels not shown in prefix-command keymaps HOT 1
- General.el byte-compile warning HOT 2
- using multi evil states/keymaps in single general-def
- keymaps not activating keymap during major-mode treemacs HOT 2
- `general-def` is not defined when used in `pre-` or `post-command-hook` HOT 1
- general is not working correctly for emacs-lisp-mode HOT 1
- Using general.el with meow HOT 4
- binding "TAB" in company-active-map to company-complete-selection problem HOT 2
- Creating a toggle to activate/deactivate keybindings HOT 3
- How to use custom definer in use-package definition? HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from general.el.