Giter VIP home page Giter VIP logo

Comments (3)

noctuid avatar noctuid commented on August 16, 2024

Yeah, the basic workaround would be to handle insert specially or more generally look at all keymap and state aliases. I'm okay with that, but maybe the current check should be completely changed. It won't work in other cases too (the key definer function might not yet be defined when the check happens). Maybe there needs to be a specific list of definers to check against that can be automatically populated by general-create-definer at expansion time. That would probably be more inconvenient if someone was using custom definers not created with general-create-definer though. I'll have to think about the best way to handle this. Probably I'll just check against aliases first and then add a note to the readme that custom definers need to be available at expansion time with an example for a compiled init.

from general.el.

VojtechStep avatar VojtechStep commented on August 16, 2024

Maybe we can use symbol properties? So that general-create-definer automatically sets the property on the definer symbol, and anyone using an unsupported setup can do so manually.

from general.el.

noctuid avatar noctuid commented on August 16, 2024

It might cause some issues for people when updating general.el (maybe the new behavior should be opt-in for a while), but I think that's the correct way to handle it.

from general.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.