Giter VIP home page Giter VIP logo

Comments (4)

ixti avatar ixti commented on August 18, 2024

Can you please provide a broken YAML example, so I could play with it.
You can either send it to my by e-mail, or fork js-yaml repo and put "failing" YAML file as ./test/issues/data/issue-54.yml

from js-yaml.

maxp avatar maxp commented on August 18, 2024

js and yaml:
https://gist.github.com/3997997
https://gist.github.com/3998001

That file filled with cyrillic letter 'ัƒ' (two bytes).

The bug appears near 8k buffer boundary on odd aligned utf8 bytes.
Reader splits bytes of the character and produces two broken symbols.

from js-yaml.

ixti avatar ixti commented on August 18, 2024

Yes, you're absolutely right. We read stream by 4K chunks, so it gets broken when it reads half of a unicode char.

from js-yaml.

ixti avatar ixti commented on August 18, 2024

As we are not using asynchronous work with input streams, there was no point of using fs.openFile under the hood. So I completely dropped support of raw Buffers and file descriptors in favor of plain Strings.

from js-yaml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.