Comments (8)
Until we have a consistently green and consistently functioning CI, this is going to be dang near impossible to do. There is too much in the landing process that requires manual intervention, not the least of which is interpreting CI results.
from automation.
@jasnell it could be kicked off only at the point you would manually do it yourself. That would remove the potential for error when landing the commit
from automation.
The Rust project has a https://github.com/bors IIUC it pretty much does the same kind of stuff, but on Github. Pick a merged PR to see what it does.
from automation.
Refs: nodejs/build#705
There's seems to be prior art, I'll try to find references.
from automation.
Until we have a consistently green and consistently functioning CI, this is going to be dang near impossible to do.
It's not a big deal in practice. Rust doesn't have that either, getting something landed sometimes takes a few retries, but it's okay because it's automated.
I for one would be very pleased if this went through.
from automation.
;) Ok... So long as it is focused on the after CI bits, I'm +1. Eventually we need to take a serious look at CI tho
from automation.
If anything the commit queue increases the incentive to fix flakiness.
from automation.
Some thoughts on the next step of node-core-utils
: https://github.com/joyeecheung/node-core-utils/issues/10 , could potentially be used by the bot, right now the goal is "good enough for human to use".
from automation.
Related Issues (20)
- Should Automation take ownership of make-node-meeting? HOT 6
- What about a related project for @nodejs/automation projects utils? HOT 19
- Proposing to form a monorepo HOT 14
- Can we automate appending changelogs to a release HOT 3
- Side effect: Working with Build WG to change description on Nodejs.org ? HOT 9
- CitGM testing Node-Core-Utils? HOT 10
- Include collaborators/team members in the README? HOT 8
- Idea: A twitter bot to thank new contributors HOT 4
- An app for managing bans HOT 8
- greenkeeper-like feature for ncu-team HOT 5
- Use ncu-team in create-node-meeting-artifacts HOT 1
- avoid CI typos HOT 6
- Tool for generating/maintaining/auditing CODEOWNER file HOT 12
- doc REPLACEME linter/fixer HOT 3
- explore k8s prow as a way to automate stuff in github HOT 4
- Github team management (reply here if you want to join) HOT 33
- Node.js clone repo for testing HOT 6
- Brigade HOT 3
- Repo and npm accesses of related projects HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automation.