Comments (6)
I've been looking into this, and as an aside point, the instructions about installing Chart.js and Chart.Scatter.js (https://github.com/nodejs/benchmarking/tree/master/tools/chartGen/lib) would benefit by being more specific on versions needed. I found that the lastest versions of the libraries weren't compatible with the chart get code.
@mhdawson was able to provide me a copy of the versions running in CI (Chart.js is at 1.0.2, latest is 2.4.0) and a copy of the results database. My findings so far is that the html that's generated looks correct when viewed in a browser. The problem seems to occur when phantomjs is used to create the png snapshot. This rendering misaligns the data against the Y axis. I'm trying to determine what the cause of this is.
from benchmarking.
The problem was in because the data on the charts animates into view. There was already a 1 second delay for the page to complete before the screen shot was taken, but this wasn't enough to finish the animation. I've just added a PR to turn the animation off - I've tested this and the generated png files look the same as the actual html
from benchmarking.
PR for fix went in, had validated one chart so expect it will resolve. Will validate/close this issue once charts are next fully transferred to benchmarking.nodejs.org.
from benchmarking.
@CurryKitten can you also submit a PR to update the instructions to specify the versions needed so that we can recreate in case of machine loss.
from benchmarking.
@mhdawson Yes - I'll double check those versions and add an appropriate PR
from benchmarking.
Ok, sniff checked acemair latency and value in job from last night matches what we get on the chart in respect to the Y axis in chart on benchmarking.nodejs.org. closing.
from benchmarking.
Related Issues (20)
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-08-20 HOT 2
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-09-10 HOT 6
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-10-01 HOT 4
- Benchmarking runs - not running on some versions? HOT 1
- Look into optimizing the generated images HOT 1
- Benchmark Popularity Survey
- Benchmarking Heap/Memory Used HOT 1
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-10-22 HOT 1
- styles.css not found HOT 8
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-10-28
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-11-12 HOT 2
- select-compiler in benchmark script HOT 2
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-12-03
- Node.js Foundation Benchmarking WorkGroup Meeting 2019-12-24 HOT 3
- Node.js Foundation Benchmarking WorkGroup Meeting 2020-01-14 HOT 2
- Benchmarks for popular Web Frameworks
- Node.js Foundation Benchmarking WorkGroup Meeting 2020-02-18 HOT 4
- Better visualization of the data? HOT 1
- Adding @puzpuzpuz to @nodejs/benchmarking HOT 3
- Running a benchmark HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benchmarking.