Comments (7)
would have approached it differently, having no stack trace by default (if you use dot you usually don't want the output to be verbose) and opt in with a flag
--debug
flag or--verbose
(like phpunit).
Not sure if it's a good idea to change the behavior again, at this point I'd add a flag skip stack traces
no reason for it to be a flag. it can be two separate reporters. the only question is if they should both reside in core, or should one be in user-land?
I am ok with having dot
and dot-verbose
reporters, or alternatively dot
and dot-compact
from node.
I would have approached it differently, having no stack trace by default (if you use dot you usually don't want the output to be verbose) and opt in with a flag --debug
flag or --verbose
(like phpunit).
Not sure if it's a good idea to change the behavior again, at this point I'd add a flag skip stack traces
from node.
I've internalized the previous version of the dot runner given how small and simple it was.
https://github.com/csstools/postcss-plugins/blob/main/packages/postcss-tape/test/_dot-reporter.cjs
Feel free to close this issue.
from node.
This behavior was changed in #52655, does that answer your question?
@nodejs/test_runner is there a way to revert the behavior via a CLI flag or similar?
from node.
Marking as feature-request
, as it appears this is requesting a way to disable the new dot reporter.
from node.
Now that this is labeled as a feature request I should explain better why I saw value in the previous implementation of the dot reporter.
We author a lot of PostCSS plugins and also have our own test suite for PostCSS plugins.
This test suite is built on top of node:test
.
To test this test suite itself we decided to use the dot reporter exactly because it only gives feedback on passes and failures.
This makes it easy to verify that failing tests fail in the expected way.
We are only interested in the sequence of passes and failures and the final exit code.
Information like stack traces is not helpful for our purposes because these can be different for each user and environment.
The lack of detailed information in the dot reporter also gave us the impression that it would be stable across node versions.
With the recent changes it is both unstable between node versions (because it is a new addition) and it is unstable between users.
This makes it impossible to record test runner output and compare new runs against previous recordings.
from node.
Not sure if it's a good idea to change the behavior again
Changing it back has the benefit that it restores the previous behavior.
That makes it possible to test over multiple node versions (all the way back to node 18 if I recall correctly) and have consistent output.
Introducing a new dot-compact
doesn't have this benefit.
from node.
Related Issues (20)
- (Discuss) `_stream_*`
- Failed to build node in windows because dependency openssl.lib didn't build
- Keep fs.exists not deprecated HOT 2
- CVE-2024-28863 in Nodejs.18 HOT 3
- Linking uses too much memory when building v22.2.0 on macOS HOT 3
- Wtn
- Estoy compartiendo 'WTN.CSV' con usted desde WPS Office
- No such built-in module: sea HOT 6
- `DOMException`s do not work with `v8.serialize()`
- In "fs.copyFile(src, dest[, mode], callback)" , for callback,'err' is not defined. HOT 5
- /rbd/pnpm-volume/040a3e2e-c162-47cf-9d77-c827c149c920/node_modules/@discordjs/util/dist/index.js:39 return () => defaultValue ??= cb(); ^^^ SyntaxError: Unexpected token '??=' at wrapSafe (internal/modules/cjs/loader.js:1001:16) at Module._compile (internal/modules/cjs/loader.js:1049:27) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10) at Module.load (internal/modules/cjs/loader.js:950:32) at Function.Module._load (internal/modules/cjs/loader.js:790:12) at Module.require (internal/modules/cjs/loader.js:974:19) at require (internal/modules/cjs/helpers.js:101:18) at Object.<anonymous> (/rbd/pnpm-volume/040a3e2e-c162-47cf-9d77-c827c149c920/node_modules/discord.js/src/index.js:3:29) at Module._compile (internal/modules/cjs/loader.js:1085:14) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10) HOT 1
- Fatal error nullptr check in AsyncModuleExecutionFulfilled HOT 1
- Inconsistent output depending on if it's piped somewhere or not HOT 4
- Build fail on macOS arm64 - ld: symbol(s) not found for architecture arm64 HOT 1
- Expose SQLite? HOT 1
- Source maps not working when source code is piped in
- Migrating from object.ref()/object.unref() to process.ref()/process.unref() HOT 2
- import sqlite3 is throwing nodejs error and killing the script HOT 1
- Change logo HOT 1
- Change logo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.