Giter VIP home page Giter VIP logo

Comments (3)

ronag avatar ronag commented on June 20, 2024 1

I tried an alternative approach to more clearly separate the logic #2816

from undici.

metcoder95 avatar metcoder95 commented on June 20, 2024

Hmm, it sounds doable; but how do we handle the fact that we start the negotiation in the same way, it might seem counterintuitive to have to decide whether to use one or the other depending on the ALPN step.

A couple of things can bring some light on this, e.g., if not using TLS we cannot even try an H2 request, or if the flag is disabled, we do not do that.

One thing that can work is to remove the writeH2 and scope it to a mid-term dispatcher; that, if ALPN states to use H2 we simply use it instead, and pass the socket (pretty much as you opened PR, but the control is passed to that dispatcher, and the main dispatcher just passes the handler)

from undici.

mcollina avatar mcollina commented on June 20, 2024

+1 to the idea

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.