Giter VIP home page Giter VIP logo

Comments (10)

mcollina avatar mcollina commented on July 20, 2024 1

I think it's safe to say we support only recent versions of Node.js and we didn't update package.json.

Mostly because we do not test for them.
I generically follow the rule that only the latest version of a series is supported, mostly because it's impossible work to test them all and we should be encouraging people to upgrade

from undici.

Uzlopak avatar Uzlopak commented on July 20, 2024

Why not upgrading node version too?

from undici.

KhafraDev avatar KhafraDev commented on July 20, 2024

Why not upgrading node version too?

This isn't relevant.


This is caused by 8a07bbd which uses stream.finished. The node docs did not mention that support for web streams was added in some unknown v18 release ☚ī¸.

The fix is either to drop support for v18 prior to said addition, or fallback to the previous solution if we can't use stream.finished.

from undici.

Uzlopak avatar Uzlopak commented on July 20, 2024

It is relevant for the decision if we drop support for node versions < 18.17.0 or if we fix the support for node 18.14.0. In fastify we expect that a reasonable version of node has to be used. so nobody can demand, that we support node 14.0.0, but we support latest node 14.

from undici.

KhafraDev avatar KhafraDev commented on July 20, 2024

node 14 is EOL, node 18 isn't

from undici.

Uzlopak avatar Uzlopak commented on July 20, 2024

it is the principle. We also dont support older versions of node 18 or 20, despite them being not EOL:

from undici.

KhafraDev avatar KhafraDev commented on July 20, 2024

That's not true, we currently support any version of node >= v18:

undici/package.json

Lines 127 to 129 in f979ec3

"engines": {
"node": ">=18.0"
},

from undici.

Uzlopak avatar Uzlopak commented on July 20, 2024

I was in the context of fastify.

from undici.

KhafraDev avatar KhafraDev commented on July 20, 2024

Please downgrade undici to v6.12.0 or upgrade your node version to the latest version of v18.

from undici.

trentm avatar trentm commented on July 20, 2024

Okay, thanks. To be clear, I don't need undici to support the older Node v18 versions for my case. I just needed to be clear what versions it did support.
It would be helpful if "engines" was updated to a realistic value, but perhaps that is difficult if the intent will be to only support the very latest.

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.