Bug Deion throwOnError does

The stream function has the same behavior: <div c

throwOnError does not work on HTTPParserError,about nodejs/undici

Comments (4)

ronag commented on July 20, 2024

Throw on error is not related to this.

throwOnError boolean (optional) - Default: false - Whether Undici should throw an error upon receiving a 4xx or 5xx response from the server.

Here is a correct version of your code that does not throw uncaught:

request('http://www.rolbox.it/rk-kastelruth/webcam/web03.jpg', { throwOnError: false })
    .then(({ body }) => body.on('error', () => console.error("body error, err")))
    .catch(e => console.error('catch called:', e))
    .finally(() => console.log('finally called'));

from undici.

sandratatarevicova commented on July 20, 2024

throwOnError boolean (optional) - Default: false - Whether Undici should throw an error upon receiving a 4xx or 5xx response from the server.

Based on this, I would expect an error to be thrown as the request ends with 404.

from undici.

sandratatarevicova commented on July 20, 2024

The stream function has the same behavior:

const fs = require('node:fs');
const { stream } = require('undici');

stream(
    'http://www.rolbox.it/rk-kastelruth/webcam/web03.jpg',
    {
        throwOnError: true,
        method: 'GET',
    },
    () => fs.createWriteStream('/tmp/test.jpg'),
)
    .then(() => console.log('then called'))
    .catch(e => console.error('catch called:', e))
    .finally(() => console.log('finally called'));

output:

node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

HTTPParserError: Response does not match the HTTP/1.1 protocol (Invalid character in chunk size)
    at Parser.execute (/private/tmp/undici-test/node_modules/undici/lib/dispatcher/client-h1.js:277:15)
    at Parser.readMore (/private/tmp/undici-test/node_modules/undici/lib/dispatcher/client-h1.js:218:12)
    at Socket.<anonymous> (/private/tmp/undici-test/node_modules/undici/lib/dispatcher/client-h1.js:669:14)
    at Socket.emit (node:events:518:28)
    at emitReadable_ (node:internal/streams/readable:832:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:81:21) {
  code: 'HPE_INVALID_CHUNK_SIZE',
  data: ' \r\n' +
    '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">\n' +
    '<HTML><HEAD>\n' +
    '<TITLE>404 Not Found</TITLE>\n' +
    '</HEAD><BODY>\n' +
    '<H1>Not Found</H1>\n' +
    'The requested URL /rk-kastelruth/webcam/web03.jpg was not found on this server.<P>\n' +
    '</BODY></HTML>\n' +
    '\r\n' +
    '0\r\n' +
    '\r\n'
}

from undici.