Giter VIP home page Giter VIP logo

Comments (11)

mhdawson avatar mhdawson commented on July 17, 2024 1

I was talking about that a bit with Richard. I don't know the undici tests well enough to know off the top of my head, but building with the option enabled and validating that the wasm file is were it's expected afterwards was what we thought might work.

from undici.

Uzlopak avatar Uzlopak commented on July 17, 2024 1

Actually it just needs like 5 more lines, I promise I will provide a PR tonight at latest midnight (German Time),

from undici.

Uzlopak avatar Uzlopak commented on July 17, 2024 1

I will also provide a test.

from undici.

ronag avatar ronag commented on July 17, 2024

@Uzlopak

from undici.

mhdawson avatar mhdawson commented on July 17, 2024

There is some discussion in the PR after it landed, goal is to add back the parts that were removed but still needed while keeping what was optimized in #3074

from undici.

Uzlopak avatar Uzlopak commented on July 17, 2024

Yes, we discussed this, I kind of lost track of it.

from undici.

mcollina avatar mcollina commented on July 17, 2024

Should we revert?

@mhdawson how can we test for this in a meaningful way so we don't regress?

from undici.

mcollina avatar mcollina commented on July 17, 2024

@mhdawson if any of you can drop a PR for this, it would be very useful to prevent further issues.

from undici.

mhdawson avatar mhdawson commented on July 17, 2024

@Uzlopak do you mean you will include the testing in your PR?

from undici.

khardix avatar khardix commented on July 17, 2024

@Uzlopak Any updates?

from undici.

mhdawson avatar mhdawson commented on July 17, 2024

@Uzlopak just wondering if there is something I can do to help this along? If you have the right way in mind to fix but just don't have time maybe we can get together to do some knowledge transfer and either myself or @richardlau can help out?

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.