Stream commands incorrect keys parsing about redis-commands HOT 7 CLOSED

See pull request #31

from redis-commands.

Could you please describe the behaviour which is causing problems? As it's written, I'm not seeing a problem.

from redis-commands.

Yes, sorry.

The problem is, that when you use ioredis, which is using this library, there is an option keyPrefix, which automaticaly adds prefix to keys in every command.

When you call xreadgroup within ioredis library, the command on redis should look like XREADGROUP GROUP groupName .... STREAMS key1

This library provides key info for first string from command, which is GROUP and when you use some prefix the command is:

XREADGROUP prefix:GROUP groupName .... STREAMS key1

instead of

XREADGROUP GROUP groupName .... STREAMS prefix:key1

from redis-commands.

This applies to XREAD as well.

from redis-commands.

This patch seems to work fine. Is there any particular reason why is this not yet merged?

from redis-commands.

This patch seems to work fine. Is there any particular reason why is this not yet merged?

There were some mistakes discussed in the pr: #31

from redis-commands.

Fixed by 43b4efe. This is included in the latest release.

from redis-commands.