[Request] Add panel-less button using html about leaflet-sidebar-v2 HOT 11 CLOSED

I can look into it in the next days.

For the CSS we don't need a new class, this selector should work well.
For JS we could then check for presence of the href attribute instead:

if (!link.hasAttribute('href') || link.getAttribute('href')[0] !== '#'))
    return;

Do you have a suggestion for a better check than href[0] !== '#'?

from leaflet-sidebar-v2.

I'm not sure about a better check for href[0], but updating
if (link.hasAttribute('href') && link.getAttribute('href')[0] !== '#')
to
if (!link.hasAttribute('href') || link.getAttribute('href')[0] !== '#'))
would probably be good regardless.

How would this feature impact sidebar.addPanel? One pro of using a class is that sidebar.addPanel would need less changes. You could add an optional property (i.e. anchorClass or tabClass) to set anchor's class when adding it via js, and both should work as expected.

from leaflet-sidebar-v2.

The proposed change would allow a sidebar button to act externally of the the sidebar. For example, clicking a gear button on the sidebar could open a modal window rather than a sidebar tab. Please let me know if I'm mistaken.

I'm cautiously supportive of the idea. Implementation needs careful consideration though.

I'm unable to see how the proposed link check would be better. Can someone provide an example? Here's a quick jsbin that compares the existing and proposed link checks with a few scenarios.

from leaflet-sidebar-v2.

@nickpeihl This feature exists already. What @ChaudhryAtif wants, is to support this in the html-markup version as well.

The change of the check allows to omit the href="javascript:void(0);" attribute for button-tabs in the markup. (Here's the same test, reworded)

from leaflet-sidebar-v2.

@noerw That makes sense to me. Thanks so much for explaining! I'm definitely in favor of this improvement.

from leaflet-sidebar-v2.

fixed in 78e4787

from leaflet-sidebar-v2.

@noerw Does this account for href being added by addPanel?

from leaflet-sidebar-v2.

Why wouldn't it? I tested this, and everything kept working

from leaflet-sidebar-v2.

Alright. Thanks for adding the feature!

from leaflet-sidebar-v2.

@noerw 3.0.1 (instead of 3.0.2) is the latest for npm install: https://www.npmjs.com/package/leaflet-sidebar-v2

from leaflet-sidebar-v2.

sorry. just pushed 3.0.2

from leaflet-sidebar-v2.