Giter VIP home page Giter VIP logo

Comments (4)

Savio-Sou avatar Savio-Sou commented on August 11, 2024 1

Most comments seem to have been addressed in previous PRs. noir-lang/book#42 should address the remaining ones below:

This should generally be the default type reached for to solve problems as using a smaller integer type like u64 incurs extra range constraints and so is less efficient rather than more.

it seems convoluted to me. But being not a native english speaker, I may be totally wrong.

Reworded: https://github.com/noir-lang/book/pull/42/files#diff-f83b6591dd0f46043bcc78d734fc1ca6174383d5e406b1662e554c116e203166R57

Note: This behaviour (n.b. pub in main arguments) and type will change in future releases, to catch a linearity bug in user code.

Why this behavior will change?

Deleted: https://github.com/noir-lang/book/pull/42/files#diff-f83b6591dd0f46043bcc78d734fc1ca6174383d5e406b1662e554c116e203166L127

An array is a data structure which allows you to group together data types

to group together data of the same type

Reworded: https://github.com/noir-lang/book/pull/42/files#diff-f83b6591dd0f46043bcc78d734fc1ca6174383d5e406b1662e554c116e203166R96

Note that currently Noir only supports arrays with integer or field elements.

we do not support array of struct?

I don't think we do yet. We can modify this when we've added support.

from docs.

vezenovm avatar vezenovm commented on August 11, 2024

I guess we are now in pre-beta instead of pre-alpha, and we do support another backend. However only the Aztec one is compatible with the ethereum contract.

Do you mean the arkworks backend's like Marlin? I don't know if we can say that we fully support them yet as they only support arithmetic gates. We still need to add some logic that converts our custom gates to arithmetic gates. We can build Noir with Marlin for example but simple examples still fail.

Section is empty, may be we want to rename it as well?

Looks like the master branch of the book has details here and has been renamed to Merkle Membership. Most likely just need to update the github pages

it seems convoluted to me. But being not a native english speaker, I may be totally wrong.

I can try and re-word this in a PR to update the docs

This should not be true anymore, odd-sized integers should be fine.

I still got this error on Noir master branch

Screen Shot 2022-09-28 at 10 15 55 PM

from docs.

vezenovm avatar vezenovm commented on August 11, 2024

Note: This behaviour (n.b. pub in main arguments) and type will change in future releases, to catch a linearity bug in user code.

Why this behavior will change?

Curious about this as well. Do you have any insight into this note @kevaundray ?

from docs.

guipublic avatar guipublic commented on August 11, 2024

...odd-sized integers should be fine.

I still got this error on Noir master branch

Good point! I removed this todo in PR #354

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.